From: John Ogness <john.ogness@linutronix.de>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH printk 4/5] printk: remove logbuf_lock, add syslog_lock
Date: Thu, 24 Sep 2020 11:27:51 +0206 [thread overview]
Message-ID: <87d02b7cnk.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <20200924084541.GA541@jagdpanzerIV.localdomain>
On 2020-09-24, Sergey Senozhatsky <sergey.senozhatsky@gmail.com> wrote:
> [..]
>> void printk_safe_flush_on_panic(void)
>> {
>> - /*
>> - * Make sure that we could access the main ring buffer.
>> - * Do not risk a double release when more CPUs are up.
>> - */
>> - if (raw_spin_is_locked(&logbuf_lock)) {
>> - if (num_online_cpus() > 1)
>> - return;
>> -
>> - debug_locks_off();
>> - raw_spin_lock_init(&logbuf_lock);
>
> If we panic() with syslog_lock locked then we need to zap syslog_lock
> and disable debug_locks for kmsg_dump() to succeed. Otherwise panic()
> may deadlock:
>
> syslog_lock_irq()
> -> NMI
> panic()
> ...
> printk_safe_flush_on_panic();
> kmsg_dump(KMSG_DUMP_PANIC); // syslog_lock_irqsave(flags)
> ...
>
> Did I miss the point where we make sure that kmsg_dump() will not
> deadlock?
You are correct. Thanks.
@clear_seq should either become atomic64 or kmsg_dump() should start
from the oldest available message (seq=0).
John Ogness
next prev parent reply other threads:[~2020-09-24 9:21 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 15:38 [PATCH printk 0/5] printk: remove logbuf_lock John Ogness
2020-09-22 15:38 ` [PATCH printk 1/5] printk: get new seq before enabling interrupts John Ogness
2020-09-23 14:17 ` Petr Mladek
2020-09-23 14:36 ` John Ogness
2020-09-22 15:38 ` [PATCH printk 2/5] printk: kmsg_dump_rewind_nolock: start from first record John Ogness
2020-09-23 14:52 ` Petr Mladek
2020-09-23 15:39 ` John Ogness
2020-09-22 15:38 ` [PATCH printk 3/5] printk: use buffer pool for sprint buffers John Ogness
2020-09-23 15:11 ` Petr Mladek
2020-09-23 15:21 ` David Laight
2020-09-23 16:41 ` Petr Mladek
2020-09-24 5:40 ` Sergey Senozhatsky
2020-09-24 8:45 ` Petr Mladek
2020-09-24 8:53 ` Sergey Senozhatsky
2020-09-24 9:49 ` Rasmus Villemoes
2020-09-25 8:15 ` Petr Mladek
2020-09-24 9:54 ` Rasmus Villemoes
2020-09-24 12:32 ` Rasmus Villemoes
2020-09-25 8:28 ` Petr Mladek
2020-09-30 8:06 ` Rasmus Villemoes
2020-09-30 8:51 ` Petr Mladek
2020-09-30 8:57 ` John Ogness
2020-09-30 13:35 ` Steven Rostedt
2020-09-30 14:32 ` David Laight
2020-10-01 7:15 ` Rasmus Villemoes
2020-10-01 7:58 ` Petr Mladek
2020-09-24 1:21 ` Sergey Senozhatsky
2020-09-24 6:17 ` Sergey Senozhatsky
2020-09-24 8:54 ` Petr Mladek
2020-09-24 9:06 ` Sergey Senozhatsky
2020-09-25 8:13 ` Petr Mladek
2020-09-22 15:38 ` [PATCH printk 4/5] printk: remove logbuf_lock, add syslog_lock John Ogness
2020-09-23 16:30 ` Petr Mladek
2020-09-24 8:45 ` Sergey Senozhatsky
2020-09-24 9:21 ` John Ogness [this message]
2020-09-22 15:38 ` [PATCH printk 5/5] printk: remove nmi safe buffers John Ogness
2020-09-23 16:36 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d02b7cnk.fsf@jogness.linutronix.de \
--to=john.ogness@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox