From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1243EC2BA19 for ; Tue, 14 Apr 2020 16:52:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C99F42074D for ; Tue, 14 Apr 2020 16:52:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AH+xoIgY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2502352AbgDNQwU (ORCPT ); Tue, 14 Apr 2020 12:52:20 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:50028 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2441029AbgDNQvS (ORCPT ); Tue, 14 Apr 2020 12:51:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586883077; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xEwW/84Bx+Wn4UVzdKy29mX/tgdsrLXZkRwHZ2M75ns=; b=AH+xoIgYnCAHv9ZmXyrRI2RLrNizErROBc4D/B1HKpjc7Y5kx/14yCp10LLIRWYM+pqYdK VBrZONbC1bnufWaQb1QR9uDQKdlF2n9PS/HkQy0BLIzdr5QerGx5MUljpne60GirQ5pLHD ls2lCzuWwHwMZ8vnkY4NbwcUjBERNls= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-279-1cSpM5MuMS-25Gm7FYRJJQ-1; Tue, 14 Apr 2020 12:51:15 -0400 X-MC-Unique: 1cSpM5MuMS-25Gm7FYRJJQ-1 Received: by mail-wm1-f69.google.com with SMTP id f8so4530499wmh.4 for ; Tue, 14 Apr 2020 09:51:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=xEwW/84Bx+Wn4UVzdKy29mX/tgdsrLXZkRwHZ2M75ns=; b=bNZ//FX//pCHpbkdzhdxp+oQUZAqXf6fYtnmnf6QmYtesJcxdDbjbpwj1O/89XkU1X CEqXM1WNNuFs85k7hsdtVzB5VRQaZ1D7e7Zo+pwzH4oYWdIXl/1KGh4ENmI1qPZ2x/Y2 2c/zbvD49lDy/9D2WJfUD8TmfPhuBIMt+MzmNrRbfum1itytrpZfrxwiaE7KuSsEJ9rT soIEE0deKQbuEoz/HV1c4l3lPosL9YzNPAj4MDTSfaV3xyeoWsSOgV3boSpzYiVTWpZi NczeROcqhEYFOSLcc5lSdUtYIfApzABHUSnoiTllbD2qiXSXkjuwyvHKUFoJ521XZldB 73WQ== X-Gm-Message-State: AGi0PubLkNjzUr5jxxtRDOLR61cgZ/Uw4DvjMgSrsZ8gx+O3XKR/2E0W CzeexjScNDCO1OKd2WjkiqJmSDZ0UshP8hr9VksGm/30PQFmX7x5XLoI8Nfy9hALpuPnkS6w7pa VDZlblmTmoJPo5qVs5NsWW5w3 X-Received: by 2002:a05:600c:2314:: with SMTP id 20mr809882wmo.118.1586883073922; Tue, 14 Apr 2020 09:51:13 -0700 (PDT) X-Google-Smtp-Source: APiQypJCdYCN7qTchgvOqHA8okoWjFJVzrdCxgqqIR560y3Z2b+3g4AVFAj455QlShPovTl9i6iVNA== X-Received: by 2002:a05:600c:2314:: with SMTP id 20mr809859wmo.118.1586883073583; Tue, 14 Apr 2020 09:51:13 -0700 (PDT) Received: from vitty.brq.redhat.com (g-server-2.ign.cz. [91.219.240.2]) by smtp.gmail.com with ESMTPSA id t20sm9185423wmi.2.2020.04.14.09.51.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2020 09:51:12 -0700 (PDT) From: Vitaly Kuznetsov To: Colin King Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, "K . Y . Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , linux-hyperv@vger.kernel.org Subject: Re: [PATCH][next] drivers: hv: remove redundant assignment to pointer primary_channel In-Reply-To: <20200414152343.243166-1-colin.king@canonical.com> References: <20200414152343.243166-1-colin.king@canonical.com> Date: Tue, 14 Apr 2020 18:51:11 +0200 Message-ID: <87d08axb7k.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Colin King writes: > From: Colin Ian King > > The pointer primary_channel is being assigned with a value that is never, > The assignment is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King > --- > drivers/hv/channel_mgmt.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c > index ffd7fffa5f83..f7bbb8dc4b0f 100644 > --- a/drivers/hv/channel_mgmt.c > +++ b/drivers/hv/channel_mgmt.c > @@ -425,8 +425,6 @@ void hv_process_channel_removal(struct vmbus_channel *channel) > > if (channel->primary_channel == NULL) { > list_del(&channel->listentry); > - > - primary_channel = channel; > } else { > primary_channel = channel->primary_channel; > spin_lock_irqsave(&primary_channel->lock, flags); If I'm looking at the right source (5.7-rc1) it *is* beeing used: if (channel->primary_channel == NULL) { list_del(&channel->listentry); primary_channel = channel; } else { primary_channel = channel->primary_channel; spin_lock_irqsave(&primary_channel->lock, flags); list_del(&channel->sc_list); spin_unlock_irqrestore(&primary_channel->lock, flags); } /* * We need to free the bit for init_vp_index() to work in the case * of sub-channel, when we reload drivers like hv_netvsc. */ if (channel->affinity_policy == HV_LOCALIZED) cpumask_clear_cpu(channel->target_cpu, &primary_channel->alloced_cpus_in_node); ^^^^^ HERE ^^^^^ -- Vitaly