Re: [PATCH v2 48/66] KVM: x86: Remove stateful CPUID handling

Jim Mattson
2020-03-03T19:23:32Z

On Mon, Mar 2, 2020 at 3:57 PM Sean Christopherson
<sean.j.christopherson@intel.com> wrote:

> diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c
> index b5dce17c070f..49527dbcc90c 100644
> --- a/arch/x86/kvm/cpuid.c
> +++ b/arch/x86/kvm/cpuid.c
> @@ -495,25 +495,16 @@ static inline int __do_cpuid_func(struct kvm_cpuid_array *array, u32 function)
> * time, with the least-significant byte in EAX enumerating the
> * number of times software should do CPUID(2, 0).
> *
> - * Modern CPUs (quite likely every CPU KVM has *ever* run on)
> - * are less idiotic. Intel's SDM states that EAX & 0xff "will
> - * always return 01H. Software should ignore this value and not
> + * Modern CPUs, i.e. every CPU KVM has *ever* run on are less

Nit: missing comma after "run on."

Reviewed-by: Jim Mattson <jmattson@google.com>