Re: [PATCH 1/2] clone3: add CLONE3_CLEAR_SIGHAND

Florian Weimer
2019-10-10T15:22:43Z

* Christian Brauner:

> On Thu, Oct 10, 2019 at 04:19:44PM +0200, Florian Weimer wrote:
>> * Christian Brauner:
>>
>> > @@ -2567,7 +2572,7 @@ static bool clone3_args_valid(const struct kernel_clone_args *kargs)
>> > * All lower bits of the flag word are taken.
>> > * Verify that no other unknown flags are passed along.
>> > */
>> > - if (kargs->flags & ~CLONE_LEGACY_FLAGS)
>> > + if (kargs->flags & ~(CLONE_LEGACY_FLAGS | CLONE3_CLEAR_SIGHAND))
>> > return false;
>>
>> Does the comment need updating? I feel it's a bit misleading now.
>
> Yeah, maybe just:
>
> /* Verify that no unknown flags are passed along. */
>
> ?

Sure, looks fine to me.

Thanks,
Florian