From: Eric Anholt <eric@anholt.net>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
David Airlie <airlied@linux.ie>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>
Subject: Re: [PATCH v2] drm/pl111: Use 64-bit arithmetic instead of 32-bit
Date: Tue, 17 Jul 2018 11:40:07 -0700 [thread overview]
Message-ID: <87d0vlg0zc.fsf@anholt.net> (raw)
In-Reply-To: <20180704142255.GA8614@embeddedor.com>
[-- Attachment #1: Type: text/plain, Size: 763 bytes --]
"Gustavo A. R. Silva" <gustavo@embeddedor.com> writes:
> Add suffix ULL to constant 1000 in order to give the compiler complete
> information about the proper arithmetic to use.
>
> Notice that such constant is used in a context that expects an
> expression of type u64 (64 bits, unsigned) and the following
> expression is currently being evaluated using 32-bit arithmetic:
>
> mode->clock * 1000
>
> Addresses-Coverity-ID: 1466139 ("Unintentional integer overflow")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
This is silly. The clock won't be over 4ghz -- we haven't seen anything
over 1024x768 on this hardware as far as I know. The u64 is for the
multiplication by width/height below.
I've still applied the patch to shut up the tool.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2018-07-17 18:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 14:22 [PATCH v2] drm/pl111: Use 64-bit arithmetic instead of 32-bit Gustavo A. R. Silva
2018-07-17 18:40 ` Eric Anholt [this message]
2018-07-17 19:52 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0vlg0zc.fsf@anholt.net \
--to=eric@anholt.net \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox