From: Kalle Valo <kvalo@codeaurora.org>
To: Andres Rodriguez <andresx7@gmail.com>
Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
mcgrof@kernel.org, alexdeucher@gmail.com,
ckoenig.leichtzumerken@gmail.com, arend.vanspriel@broadcom.com
Subject: Re: [PATCH 5/9] firmware: add functions to load firmware without warnings v4
Date: Fri, 20 Apr 2018 13:28:24 +0300 [thread overview]
Message-ID: <87d0yui33r.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20180417153307.3693-6-andresx7@gmail.com> (Andres Rodriguez's message of "Tue, 17 Apr 2018 11:33:03 -0400")
Andres Rodriguez <andresx7@gmail.com> writes:
> Currently the firmware loader only exposes one silent path for querying
> optional firmware, and that is firmware_request_direct(). This function
> also disables the fallback path, which might not always be the
> desired behaviour. [0]
>
> This patch introduces variations of firmware_request() and
> firmware_request_nowait() that enable the caller to disable the
> undesired warning messages. This is equivalent to adding FW_OPT_NO_WARN,
> to the old behaviour.
>
> v2: add header prototype, use updated opt_flags
> v3: split debug message to separate patch
> added _nowait variant
> added documentation
> v4: fix kernel-doc style
>
> [0]: https://git.kernel.org/linus/c0cc00f250e1
>
> Signed-off-by: Andres Rodriguez <andresx7@gmail.com>
> ---
> .../driver-api/firmware/request_firmware.rst | 13 ++++--
> drivers/base/firmware_loader/main.c | 52 ++++++++++++++++++++--
> include/linux/firmware.h | 6 +++
> 3 files changed, 63 insertions(+), 8 deletions(-)
The changelog should be after the "---" line, this way git-am will
automatically discard it.
--
Kalle Valo
next prev parent reply other threads:[~2018-04-20 10:28 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 15:32 [PATCH 0/9] Loading optional firmware v3 Andres Rodriguez
2018-04-17 15:32 ` [PATCH 1/9] firmware: some documentation fixes Andres Rodriguez
2018-04-17 20:59 ` Randy Dunlap
2018-04-17 15:33 ` [PATCH 2/9] firmware: wrap FW_OPT_* into an enum Andres Rodriguez
2018-04-21 13:57 ` Luis R. Rodriguez
2018-04-17 15:33 ` [PATCH 3/9] firmware: add kernel-doc for enum fw_opt Andres Rodriguez
2018-04-21 14:26 ` Luis R. Rodriguez
2018-04-17 15:33 ` [PATCH 4/9] firmware: use () to terminate kernel-doc function names Andres Rodriguez
2018-04-17 20:56 ` Randy Dunlap
2018-04-17 15:33 ` [PATCH 5/9] firmware: add functions to load firmware without warnings v4 Andres Rodriguez
2018-04-20 10:28 ` Kalle Valo [this message]
2018-04-21 14:32 ` Luis R. Rodriguez
2018-04-21 14:49 ` Luis R. Rodriguez
2018-04-21 15:11 ` Kees Cook
2018-04-21 15:32 ` Linus Torvalds
2018-04-21 17:36 ` Luis R. Rodriguez
2018-04-22 20:26 ` Luis R. Rodriguez
2018-04-17 15:33 ` [PATCH 6/9] firmware: print firmware name on fallback path Andres Rodriguez
2018-04-17 15:33 ` [PATCH 7/9] drm/amdgpu: use firmware_request_nowarn to load firmware Andres Rodriguez
2018-04-17 15:33 ` [PATCH 8/9] ath10k: use request_firmware_nowarn " Andres Rodriguez
2018-04-20 10:19 ` Kalle Valo
2018-04-17 15:33 ` [PATCH 9/9] brcmfmac: use request_firmware_nowait2 to load firmware without warnings Andres Rodriguez
2018-04-20 10:26 ` Kalle Valo
2018-04-20 19:33 ` Andres Rodriguez
2018-04-21 7:19 ` Kalle Valo
2018-04-21 8:04 ` Arend van Spriel
2018-04-23 13:54 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0yui33r.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=alexdeucher@gmail.com \
--cc=andresx7@gmail.com \
--cc=arend.vanspriel@broadcom.com \
--cc=ckoenig.leichtzumerken@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox