From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754676AbdGNRWx (ORCPT <rfc822;w@1wt.eu>);
        Fri, 14 Jul 2017 13:22:53 -0400
Received: from mga01.intel.com ([192.55.52.88]:53945 "EHLO mga01.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753568AbdGNRWw (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 14 Jul 2017 13:22:52 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.40,359,1496127600"; 
   d="scan'208";a="993069811"
From: Andi Kleen <andi@firstfloor.org>
To: Jiri Olsa <jolsa@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
        lkml <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Kan Liang <kan.liang@intel.com>
Subject: Re: [PATCH] perf/x86/intel: Fix debug_store reset field for freq events
References: <20170714163551.19459-1-jolsa@kernel.org>
Date: Fri, 14 Jul 2017 10:22:49 -0700
In-Reply-To: <20170714163551.19459-1-jolsa@kernel.org> (Jiri Olsa's message of
        "Fri, 14 Jul 2017 18:35:51 +0200")
Message-ID: <87d193lyqe.fsf@firstfloor.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Jiri Olsa <jolsa@kernel.org> writes:
>
> Setting the reset field to 0 for freq events.

Looks good to me.

Reviewed-by: Andi Kleen <ak@linux.intel.com>

BTW I suspect there's a related bug that

perf record -e '{cycles:pp,branches}:S' ..

would enable multi record PEBS, even though it shouldn't because
we need the PMI to read the other events.

-Andi