From: Jani Nikula <jani.nikula@linux.intel.com>
To: changbin.du@intel.com, mmarek@suse.com, corbet@lwn.net
Cc: yann.morin.1998@free.fr, linux-kbuild@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
jim.epost@gmail.com, Changbin Du <changbin.du@intel.com>
Subject: Re: [PATCH v2 1/2] kconfig/mconf: add jumping tip in title of search result textbox
Date: Wed, 08 Feb 2017 10:07:58 +0200 [thread overview]
Message-ID: <87d1etumu9.fsf@intel.com> (raw)
In-Reply-To: <20170208030939.10146-2-changbin.du@intel.com>
On Wed, 08 Feb 2017, changbin.du@intel.com wrote:
> From: Changbin Du <changbin.du@intel.com>
>
> Prompt user how to quickly jump to the item he/she is interested in.
>
> Signed-off-by: Changbin Du <changbin.du@intel.com>
> Reviewed-by: Jani Nikula <jani.nikula@linux.intel.com>
This is assuming too much... but I looked at it now, and it looks good
to me.
Thanks,
Jani.
> ---
> scripts/kconfig/mconf.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/kconfig/mconf.c b/scripts/kconfig/mconf.c
> index 315ce2c..23d5681 100644
> --- a/scripts/kconfig/mconf.c
> +++ b/scripts/kconfig/mconf.c
> @@ -443,10 +443,10 @@ static void search_conf(void)
>
> res = get_relations_str(sym_arr, &head);
> set_subtitle();
> - dres = show_textbox_ext(_("Search Results"), (char *)
> - str_get(&res), 0, 0, keys, &vscroll,
> - &hscroll, &update_text, (void *)
> - &data);
> + dres = show_textbox_ext(
> + _("Search Results (type the number to jump)"),
> + (char *)str_get(&res), 0, 0, keys, &vscroll,
> + &hscroll, &update_text, (void *)&data);
> again = false;
> for (i = 0; i < JUMP_NB && keys[i]; i++)
> if (dres == keys[i]) {
--
Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2017-02-08 8:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-06 7:46 [PATCH 0/2] kconfig/mconf: propagate jumping function in search result view changbin.du
2017-02-06 7:46 ` [PATCH 1/2] kconfig/mconf: add jumping tip in title of search result textbox changbin.du
2017-02-06 12:00 ` Jani Nikula
2017-02-07 3:10 ` Du, Changbin
2017-02-06 7:46 ` [PATCH 2/2] Documentation/kconfig: add search jump feature description changbin.du
2017-02-06 14:42 ` Jim Davis
2017-02-07 3:06 ` Du, Changbin
2017-02-08 3:09 ` [PATCH v2 0/2] kconfig/mconf: propagate jumping function in search result view changbin.du
2017-03-06 10:28 ` Du, Changbin
2017-03-23 5:35 ` Du, Changbin
2017-03-23 10:17 ` Jani Nikula
2017-02-08 3:09 ` [PATCH v2 1/2] kconfig/mconf: add jumping tip in title of search result textbox changbin.du
2017-02-08 8:07 ` Jani Nikula [this message]
2017-02-08 3:09 ` [PATCH v2 2/2] Documentation/kconfig: add search jump feature description changbin.du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1etumu9.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=changbin.du@intel.com \
--cc=corbet@lwn.net \
--cc=jim.epost@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox