From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Rob Herring <robh@kernel.org>
Cc: Ziji Hu <huziji@marvell.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Adrian Hunter <adrian.hunter@intel.com>,
<linux-mmc@vger.kernel.org>, Jason Cooper <jason@lakedaemon.net>,
Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
<devicetree@vger.kernel.org>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
<linux-arm-kernel@lists.infradead.org>,
"Jack\(SH\) Zhu" <jmzhu@marvell.com>, Jimmy Xu <zmxu@marvell.com>,
Jisheng Zhang <jszhang@marvell.com>,
Nadav Haklai <nadavh@marvell.com>, Ryan Gao <ygao@marvell.com>,
Doug Jones <dougj@marvell.com>,
Shiwu Zhang <zhangshw@marvell.com>, Victor Gu <xigu@marvell.com>,
"Wei\(SOCP\) Liu" <liuw@marvell.com>,
Wilson Ding <dingwei@marvell.com>,
Xueping Liu <xpliu@marvell.com>,
Hilbert Zhang <zzhang@marvell.com>, Keji Zhang <keji@marvell.com>,
Liuliu Zhao <zhaoliul@marvell.com>,
Peng Zhu <zhupeng@marvell.com>, Yu Cao <yucao@marvell.com>,
Romain Perier <romain.perier@free-electrons.com>,
Yehuda Yitschak <yehuday@marvell.com>,
Marcin Wojtas <mw@semihalf.com>, Hanna Hawa <hannah@marvell.com>,
Kostya Porotchkin <kostap@marvell.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/10] dt: bindings: Add bindings for Marvell Xenon SD Host Controller
Date: Tue, 22 Nov 2016 18:23:16 +0100 [thread overview]
Message-ID: <87d1hno2d7.fsf@free-electrons.com> (raw)
In-Reply-To: <15b06a12-ed69-03a7-ccc7-0c133ce1ac1e@marvell.com> (Ziji Hu's message of "Thu, 10 Nov 2016 19:44:19 +0800")
Hi Rob,
On jeu., nov. 10 2016, Ziji Hu <huziji@marvell.com> wrote:
[...]
>>> +
>>> +- reg:
>>> + * For "marvell,xenon-sdhci", one register area for Xenon IP.
>>> +
>>> + * For "marvell,armada-3700-sdhci", two register areas.
>>> + The first one for Xenon IP register. The second one for the Armada 3700 SOC
>>> + PHY PAD Voltage Control register.
>>> + Please follow the examples with compatible "marvell,armada-3700-sdhci"
>>> + in below.
>>> + Please also check property marvell,pad-type in below.
>>> +
>>> +Optional Properties:
>>> +- marvell,xenon-slotno:
>>
>> Multiple slots should be represented as child nodes IMO. I think some
>> other bindings already do this.
>>
>
> All the slots are entirely independent.
> I prefer to consider it as multiple independent SDHCs placed in
> a single IP, instead of that a IP contains multiple child slots.
It was indeed what I tried to show in my answer for the 1st version:
http://lists.infradead.org/pipermail/linux-arm-kernel/2016-October/461860.html
Maybe you missed it.
You also mentioned other bindings using child nodes, but for this one
we have one controller with only one set of register with multiple slots
(Atmel is an example). Here each slot have it own set of register.
Actually giving the fact that each slot is controlled by a different set
of register I wonder why the hardware can't also deduce the slot number
from the address register. For me it looks like an hardware bug but we
have to deal with it.
Do you still think we needchild node here?
>
> It is unlike the implementation which put multiple slots behind PCIe EP interface. sdhci-pci.c will handle each slot init one by one.
> If Xenon SDHC slots are represented as child nodes, there should also be a main entry in Xenon driver to init each child node one by one.
> In my very own opinion, it is inconvenient and unnecessary.
Gregory
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2016-11-22 17:32 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-31 11:09 [PATCH 0/10] mmc: Add support to Marvell Xenon SD Host Controller Gregory CLEMENT
2016-10-31 11:09 ` [PATCH 1/10] mmc: sdhci: Export sdhci_set_ios() from sdhci.c Gregory CLEMENT
2016-10-31 11:09 ` [PATCH 2/10] mmc: sdhci: Export sdhci_start_signal_voltage_switch() in sdhci.c Gregory CLEMENT
2016-10-31 11:09 ` [PATCH 3/10] mmc: sdhci: Export sdhci_execute_tuning() " Gregory CLEMENT
2016-10-31 11:09 ` [PATCH 4/10] MAINTAINERS: add entry for Marvell Xenon MMC Host Controller drivers Gregory CLEMENT
2016-10-31 11:09 ` [PATCH 5/10] dt: bindings: Add bindings for Marvell Xenon SD Host Controller Gregory CLEMENT
2016-11-09 18:24 ` Rob Herring
2016-11-10 11:44 ` Ziji Hu
2016-11-11 3:22 ` Jisheng Zhang
2016-11-11 3:33 ` Jisheng Zhang
2016-11-22 17:23 ` Gregory CLEMENT [this message]
2016-11-24 9:05 ` Ulf Hansson
2016-11-24 9:11 ` Arnd Bergmann
2016-11-24 9:22 ` Gregory CLEMENT
2016-11-24 9:34 ` Arnd Bergmann
[not found] ` <8737ihmctr.fsf@free-electrons.com>
2016-11-24 9:48 ` Thomas Petazzoni
2016-11-24 10:04 ` Arnd Bergmann
2016-11-24 9:49 ` Marcin Wojtas
2016-11-24 10:10 ` Thomas Petazzoni
2016-11-24 10:38 ` Ziji Hu
2016-10-31 11:09 ` [PATCH 6/10] mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality Gregory CLEMENT
2016-11-24 10:43 ` Ulf Hansson
2016-11-24 12:41 ` Ziji Hu
2016-11-24 13:34 ` Ulf Hansson
2016-11-24 15:00 ` Ziji Hu
2016-11-25 8:45 ` Ziji Hu
2016-11-25 13:06 ` Ulf Hansson
2016-11-25 13:43 ` Ziji Hu
2016-11-25 13:01 ` Ulf Hansson
2016-11-25 14:04 ` Adrian Hunter
2016-10-31 11:09 ` [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC Gregory CLEMENT
2016-11-24 9:56 ` Arnd Bergmann
2016-11-24 10:57 ` Ziji Hu
2016-11-24 11:09 ` Arnd Bergmann
2016-11-24 11:37 ` Ulf Hansson
2016-11-24 13:34 ` Ziji Hu
2016-11-24 14:33 ` Ulf Hansson
2016-11-24 15:37 ` Ziji Hu
2016-11-28 10:10 ` Ziji Hu
2016-11-28 11:13 ` Ulf Hansson
2016-11-28 11:38 ` Ziji Hu
2016-11-28 15:16 ` Ulf Hansson
2016-11-29 2:53 ` Ziji Hu
2016-11-29 7:49 ` Ulf Hansson
2016-11-29 10:33 ` Ziji Hu
2016-11-29 11:11 ` Ulf Hansson
2016-11-29 12:00 ` Ziji Hu
2016-11-28 11:09 ` Ulf Hansson
2016-10-31 11:09 ` [PATCH 8/10] arm64: dts: marvell: add eMMC support for Armada 37xx Gregory CLEMENT
2016-10-31 11:09 ` [PATCH 9/10] arm64: dts: marvell: add sdhci support for Armada 7K/8K Gregory CLEMENT
2016-10-31 11:09 ` [PATCH 10/10] arm64: configs: enable SDHCI driver for Xenon Gregory CLEMENT
2016-11-04 11:20 ` [PATCH 0/10] mmc: Add support to Marvell Xenon SD Host Controller Gregory CLEMENT
2016-11-23 8:30 ` Gregory CLEMENT
-- strict thread matches above, loose matches on Subject: below --
2016-10-07 15:22 Gregory CLEMENT
2016-10-07 15:22 ` [PATCH 5/10] dt: bindings: Add bindings for " Gregory CLEMENT
2016-10-10 21:34 ` Rob Herring
2016-10-11 10:03 ` Ziji Hu
2016-10-18 13:29 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1hno2d7.fsf@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=adrian.hunter@intel.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=dingwei@marvell.com \
--cc=dougj@marvell.com \
--cc=hannah@marvell.com \
--cc=huziji@marvell.com \
--cc=jason@lakedaemon.net \
--cc=jmzhu@marvell.com \
--cc=jszhang@marvell.com \
--cc=keji@marvell.com \
--cc=kostap@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=liuw@marvell.com \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=robh@kernel.org \
--cc=romain.perier@free-electrons.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=ulf.hansson@linaro.org \
--cc=xigu@marvell.com \
--cc=xpliu@marvell.com \
--cc=yehuday@marvell.com \
--cc=ygao@marvell.com \
--cc=yucao@marvell.com \
--cc=zhangshw@marvell.com \
--cc=zhaoliul@marvell.com \
--cc=zhupeng@marvell.com \
--cc=zmxu@marvell.com \
--cc=zzhang@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox