From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933810AbcHYMOs (ORCPT ); Thu, 25 Aug 2016 08:14:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40174 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933383AbcHYMOr (ORCPT ); Thu, 25 Aug 2016 08:14:47 -0400 From: Vitaly Kuznetsov To: Yauheni Kaliuta Cc: kys@exchange.microsoft.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com, jasowang@redhat.com, leann.ogasawara@canonical.com, alexng@microsoft.com Subject: Re: [PATCH 2/5] Drivers: hv: balloon: account for gaps in hot add regions References: <1472080943-29654-1-git-send-email-kys@exchange.microsoft.com> <1472080993-29694-1-git-send-email-kys@exchange.microsoft.com> <1472080993-29694-2-git-send-email-kys@exchange.microsoft.com> Date: Thu, 25 Aug 2016 14:13:10 +0200 In-Reply-To: (Yauheni Kaliuta's message of "Thu, 25 Aug 2016 07:53:53 +0300") Message-ID: <87d1kxavxl.fsf@vitty.brq.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.95 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Thu, 25 Aug 2016 12:13:15 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Yauheni Kaliuta writes: > Hi, kys! > >>>>>> On Wed, 24 Aug 2016 16:23:10 -0700, kys wrote: > > [...] > > > -static bool pfn_covered(unsigned long start_pfn, unsigned long pfn_cnt) > > +static int pfn_covered(unsigned long start_pfn, unsigned long pfn_cnt) > > { > > struct list_head *cur; > > struct hv_hotadd_state *has; > > + struct hv_hotadd_gap *gap; > > unsigned long residual, new_inc; > > > if (list_empty(&dm_device.ha_region_list)) > > One "return false;" left here. > This is removed in patch 4/5 of this series and false is 0 anyway) [...] -- Vitaly