From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754172AbcHVIct (ORCPT ); Mon, 22 Aug 2016 04:32:49 -0400 Received: from mga11.intel.com ([192.55.52.93]:56381 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750961AbcHVIcs (ORCPT ); Mon, 22 Aug 2016 04:32:48 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,559,1464678000"; d="scan'208";a="1045238243" From: Jani Nikula To: Heinrich Schuchardt , Patrik Jakobsson Cc: Heinrich Schuchardt , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/gma500: dont expose bytes from kernel stack In-Reply-To: <1471804778-3656-1-git-send-email-xypron.glpk@gmx.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1471804778-3656-1-git-send-email-xypron.glpk@gmx.de> User-Agent: Notmuch/0.22.1+63~g648dcc7 (https://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Mon, 22 Aug 2016 11:32:46 +0300 Message-ID: <87d1l1urtd.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 21 Aug 2016, Heinrich Schuchardt wrote: > Components m1, m2, p2, dot, vco of variable clock should be > initialized to avoid bytes from the kernel stack to be > exposed. > > Signed-off-by: Heinrich Schuchardt > --- > drivers/gpu/drm/gma500/oaktrail_crtc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/gma500/oaktrail_crtc.c b/drivers/gpu/drm/gma500/oaktrail_crtc.c > index da9fd34..28bd8f3 100644 > --- a/drivers/gpu/drm/gma500/oaktrail_crtc.c > +++ b/drivers/gpu/drm/gma500/oaktrail_crtc.c > @@ -138,6 +138,7 @@ static bool mrst_sdvo_find_best_pll(const struct gma_limit_t *limit, > u32 target_vco, actual_freq; > s32 freq_error, min_error = 100000; > > + memset(clock, 0, sizeof(struct gma_clock_t)); Did you build this? Did you run this? BR, Jani. > memset(best_clock, 0, sizeof(*best_clock)); > > for (clock.m = limit->m.min; clock.m <= limit->m.max; clock.m++) { -- Jani Nikula, Intel Open Source Technology Center