Re: [PATCH v12 2/4] gadget: Support for the usb charger framework

Baolin Wang
2016-06-21T12:34:19Z

On 21 June 2016 at 20:27, Felipe Balbi <balbi@kernel.org> wrote:
>
> Hi,
>
> Baolin Wang <baolin.wang@linaro.org> writes:
>>> Baolin Wang <baolin.wang@linaro.org> writes:
>>>>> Can't you just tie a charger to a UDC and avoid the charger class
>>>>> completely?
>>>>
>>>> Yeah, I also hope so. But we really want something to manage the
>>>> charger devices, do you have any good suggestion to avoid the 'class'
>>>> but also can manage the charger devices?
>>>
>>> manage in what way? It seems to me that they don't need to be real
>>> devices, just a handle as part of struct usb_gadget, no?
>>
>> Although charger device is not one real hardware device, we also use
>> one 'struct device' to describe it in charger.c file. So we should
>> manage the 'struct device' with one proper way.
>
> that's fine, but why do you think they need a struct device to start with?

We can get/put usb charger and mange usb charger attributes with the
device model if we use a struct device.

--
Baolin.wang
Best Regards