From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757542AbcFHPao (ORCPT ); Wed, 8 Jun 2016 11:30:44 -0400 Received: from wolverine02.qualcomm.com ([199.106.114.251]:59468 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757520AbcFHPam convert rfc822-to-8bit (ORCPT ); Wed, 8 Jun 2016 11:30:42 -0400 X-IronPort-AV: E=Sophos;i="5.26,439,1459839600"; d="scan'208";a="294346904" X-IronPort-AV: E=McAfee;i="5700,7163,8190"; a="746552410" From: "Valo, Kalle" To: Prasun Maiti CC: Linux Kernel , "ath6kl@lists.infradead.org" , Linux Next , "Linux Wireless" Subject: Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns Thread-Topic: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns Thread-Index: AQHRwZq0WCAdyrbkyEuTTMa7oGkaCg== Date: Wed, 8 Jun 2016 15:30:37 +0000 Message-ID: <87d1nrk89v.fsf@kamboji.qca.qualcomm.com> References: <1465388474-20503-1-git-send-email-prasunmaiti87@gmail.com> <87wplzkbd9.fsf@kamboji.qca.qualcomm.com> <87porrkaax.fsf@kamboji.qca.qualcomm.com> In-Reply-To: (Prasun Maiti's message of "Wed, 8 Jun 2016 20:50:40 +0530") Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.251.52.12] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Prasun Maiti writes: > I am not sure it works fine. Like ath6kl driver send another cmd to > firmare, I have just filled up the cmd buffer with "tx_ant", and > "rx_ant" values, then use "ath6kl_wmi_cmd_send()" api to send the cmd > buffer to firmware. I have resend the patch as there are some errors > in the previous patch. Let me know if any modifications are needed? I don't take untested code. In some special cases it might be ok to send untested code but even then it needs to be clearly stated in the commit log that it's untested. Please resend once you have tested this, I'm dropping this now. -- Kalle Valo