From: Rusty Russell <rusty@rustcorp.com.au>
To: Jiri Kosina <jikos@kernel.org>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2] module: fix noreturn attribute for __module_put_and_exit()
Date: Tue, 12 Apr 2016 17:00:35 +0930 [thread overview]
Message-ID: <87d1pvnv1g.fsf@rustcorp.com.au> (raw)
In-Reply-To: <alpine.LNX.2.00.1604060722140.27368@cbobk.fhfr.pm>
Jiri Kosina <jikos@kernel.org> writes:
> On Wed, 30 Mar 2016, Jiri Kosina wrote:
>
>> > __module_put_and_exit() is makred noreturn in module.h declaration, but is
>> > lacking the attribute in the definition, which makes some tools (such as
>> > sparse) unhappy. Amend the definition with the attribute as well (and
>> > reformat the declaration so that it uses more common format).
>> >
>> > Signed-off-by: Jiri Kosina <jkosina@suse.cz>
>> > ---
>> >
>> > v1 -> v2: use __noreturn instead of __attribute__((noreturn)) as requested
>> > by Rusty
>>
>> Rusty, friendly ping on this one.
>
> Not seeing this in your tree, let me send another friendly ping :)
Just pushed it into modules-next.
Cheers,
Rusty.
next prev parent reply other threads:[~2016-04-12 7:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 8:59 [PATCH] module: fix noreturn attribute for __module_put_and_exit() Jiri Kosina
2016-03-18 2:48 ` Rusty Russell
2016-03-21 10:13 ` [PATCH v2] " Jiri Kosina
2016-03-29 23:29 ` Jiri Kosina
2016-03-31 23:54 ` Rusty Russell
2016-04-01 6:31 ` Jiri Kosina
2016-04-06 5:22 ` Jiri Kosina
2016-04-12 7:30 ` Rusty Russell [this message]
2016-03-31 23:53 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1pvnv1g.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=akpm@linux-foundation.org \
--cc=jikos@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox