Re: [PATCH 8/8] gpio/mpc8xxx: Use of_mm_gpiochip_remove

Peter Korsgaard
2015-01-20T10:40:13Z

>>>>> "Ricardo" == Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> writes:

> Hello Peter
>>
>> > - hwirq = irq_of_parse_and_map(np, 0);
>> > - if (hwirq == NO_IRQ)
>> > + mpc8xxx_gc->irqn = irq_of_parse_and_map(np, 0);
>> > + if (mpc8xxx_gc->irqn == NO_IRQ)
>> > return 0;
>>
>>
>> With this return 0 converted to do of_mm_gpiochip_remove():

> Are you sure? The driver can still work as a normal gpio without the
> irq domain part and the remove function consider this option. The
> original code did also continue....

Ahh yes, you are right. Sorry, it's been a while since I wrote that code
(2008).

> If you still want to abort if no irq I can of course make the change.

No, it is fine.

--
Bye, Peter Korsgaard