From: Rusty Russell <rusty@rustcorp.com.au>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] module: log OOT_MODULE tainting
Date: Wed, 04 Jan 2012 12:22:51 +1030 [thread overview]
Message-ID: <87d3b0dyj0.fsf@rustcorp.com.au> (raw)
In-Reply-To: <alpine.LNX.2.00.1201030944270.24984@pobox.suse.cz>
On Tue, 3 Jan 2012 09:47:02 +0100 (CET), Jiri Kosina <jkosina@suse.cz> wrote:
> On Tue, 3 Jan 2012, Rusty Russell wrote:
>
> > > Follow what we do with other taints and output a message into kernel ring
> > > buffer once tainting a kernel because out-of-tree module is being loaded.
> > >
> > > Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> >
> > I don't like this, actually. There's a wish among some distributions to
> > know that OOT modules are in use in panic messages, but not by others.
> > Certainly, there's no reason to warn the user.
>
> I do get your point, but it seems to me that we are at least not
> consistent here. Why would we then log messages in cases of
> TAINT_FORCED_MODULE for example? The user knows that he has forced the
> module load, right?
Agreed, we're not consistent at all. But a forcing a module is such a
weird and risky thing to do, the user can ignore a warning message.
Cheers,
Rusty.
prev parent reply other threads:[~2012-01-04 2:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-02 13:58 [PATCH] module: log OOT_MODULE tainting Jiri Kosina
2012-01-02 22:50 ` Rusty Russell
2012-01-03 8:47 ` Jiri Kosina
2012-01-04 1:52 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d3b0dyj0.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=akpm@linux-foundation.org \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox