Re: [PATCH] Input: convert obsolete strict_strtox to kstrtox

Dmitry Torokhov
2011-11-08T03:48:15Z

Hi JJ,

On Mon, Nov 07, 2011 at 02:13:03PM +0800, JJ Ding wrote:
> Hi Dmitry,
>
> Thanks for the hint. I will send a new patch.
>
> Btw, there are still some simple_strtox uses floating around. Namely:
>
> drivers/input/joystick/analog.c:735: analog_options[i] = simple_strtoul(js[i], &end, 0);
> drivers/input/mouse/sentelic.c:415: reg = simple_strtoul(buf, &rest, 16);
> drivers/input/touchscreen/gunze.c:71: input_report_abs(dev, ABS_X, simple_strtoul(gunze->data + 1, NULL, 10));
> drivers/input/touchscreen/gunze.c:72: input_report_abs(dev, ABS_Y, 1024 - simple_strtoul(gunze->data + 6, NULL, 10));
>
> But I am not quite sure if it's safe to convert along the way. Is it OK
> to convert these?

I looked at these and I believe they do want to use simple_strtoul() as
they perform some more complex parsing there.

Thanks.

--
Dmitry