Re: [PATCH 0/2] Provide a driver for the Apple Magic Mouse - opps

Jiri Kosina
2010-02-16T12:57:10Z

On Mon, 15 Feb 2010, Ed Tomlinson wrote:

> > Almost... you need to do hid_hw_stop() first and only then unregister
> > input device, Otherwise if you unload the module while moving the mouse
> > it is likely to still oops.
>
> How about this? It applies on top of yesterdays patch.
>
> Ed
>
> ---
> diff --git a/drivers/hid/hid-magicmouse.c b/drivers/hid/hid-magicmouse.c
> index 7d252d2..46fdeee 100644
> --- a/drivers/hid/hid-magicmouse.c
> +++ b/drivers/hid/hid-magicmouse.c
> @@ -430,8 +430,8 @@ static void magicmouse_remove(struct hid_device *hdev)
> {
> struct magicmouse_sc *msc;
> msc = hid_get_drvdata(hdev);
> - input_unregister_device(msc->input);
> hid_hw_stop(hdev);
> + input_unregister_device(msc->input);
> kfree(msc);
> }

This looks OK.

Could you please send it altogether with short changelog entry and
Signed-off-by line so that I could queue that up?

Thanks,

--
Jiri Kosina
SUSE Labs, Novell Inc.