Re: [PATCH] Bluetooth: Keep a copy of each HID device's report descriptor.

Ed Tomlinson
2010-02-09T12:37:01Z

On Tuesday 09 February 2010 05:14:20 Bastien Nocera wrote:
> On Mon, 2010-02-08 at 23:22 -0800, Justin Mattock wrote:
> > > TIA
> > > Ed Tomlinson
> > >
> > > On Friday 05 February 2010 12:51:43 Marcel Holtmann wrote:
> > >> Hi Michael,
> > >>
> > >> > > looks good to me. I just prefer that you do the allocation of the report
> > >> > > descriptor before the HID object:
> > >> >
> > >> > An updated patch is below. Sorry for the delay -- inclement weather
> > >> > here got in the way of testing this as quickly as I would have liked.
> > >> >
> > >> > From e245ef87247f5e257db40c412af7991c9af375ab Mon Sep 17 00:00:00 2001
> > >> > From: Michael Poole <mdpoole@troilus.org>
> > >> > Date: Fri, 5 Feb 2010 12:21:38 -0500
> > >> > Subject: [PATCH] Bluetooth: Keep a copy of each HID device's report descriptor.
> > >> >
> > >> > The report descriptor is read by user space (via the Service
> > >> > Discovery Protocol), so it is only available during the ioctl
> > >> > to connect. However, the probe function that needs the
> > >> > descriptor might not be called until a specific module is
> > >> > loaded. Keep a copy of the descriptor so it is available for
> > >> > later use.
> > >>
> > >> patch has been applied. Thanks.
> > >>
> > >> Regards
> > >>
> > >> Marcel
> > >>
> > >>
> > >> --
> > >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > >> the body of a message to majordomo@vger.kernel.org
> > >> More majordomo info at http://vger.kernel.org/majordomo-info.html
> > >> Please read the FAQ at http://www.tux.org/lkml/
> >
> >
> > > Hi,
> > >
> > > I have been trying to test Michael's magic mouse drivers against 32.7 (or .8-rc). Is there a tree
> > > based on .32 with these patches? If not would it be possible to post the patches to lkml? I do not
> > > mind sorting out a few conflicts - this thread assume one knows a little more about the process being
> > > used here than is obvious.
> > >
> >
> >
> > just got one of those magic things as well.
> > I did apply the patchs to the current HEAD, but
> > am getting a lifeless result i.g. here's what I did:
> >
> > sudo /usr/bin/hcitool scan
> > sudo /usr/bin/simple-agent hci0 D4:9A:20:88:C7:48
> > sudo /usr/bin/dbus-send --system --dest=org.bluez --print-reply
> > /org/bluez/1897/hci0/dev_D4_9A_20_88_C7_48 org.bluez.Input.Connect
> > sudo /usr/bin/test-device trusted D4:9A:20:88:C7:48
> >
> > the thing works after that(no scroll), fast cursor though.
> > then reboot
> > once up and running nothing.
> > cat /var/log/daemon.log (shows this)
> >
> > Feb 8 22:57:40 Linux-1 bluetoothd[1973]: link_key_request
> > (sba=00:25:00:C0:6C:4F, dba=D4:9A:20:88:C7:48)
> > Feb 8 22:58:21 Linux-1 bluetoothd[1973]: last message repeated 5 times
> > Feb 8 22:59:21 Linux-1 bluetoothd[1973]: last message repeated 3 times
> > Feb 8 23:03:10 Linux-1 bluetoothd[1973]: link_key_request
> > (sba=00:25:00:C0:6C:4F, dba=D4:9A:20:88:C7:48)
>
> That means that your computer and the mouse aren't paired. The pin code
> for Apple mice is usually "0000" (as opposed to most mice which don't
> need pairing, just a poke and setting as trusted).
>
> > (could be missing something though(don't use gnome/kde-bluetooth)although
> > mightymouse works).

The magicmouse part is the easy piece. What I am looking for is the patches to the kernel
that add the new function to bluetooth allowing the extra probing. eg the patches (or tree
based on .32) that addthe initial version of "hidp_output_raw_report" and friends.

Thanks
Ed