Re: [PATCH 3/3] HID: Enable Sixaxis controller over Bluetooth

Jiri Kosina
2010-02-03T14:42:35Z

On Wed, 3 Feb 2010, Marcel Holtmann wrote:

> Hi Jiri,
>
> > Now that hid_output_raw_report works, port the PS3 Sixaxis
> > Bluetooth quirk from user-space, into kernel-space.
> >
> > Signed-off-by: Bastien Nocera <hadess@hadess.net>
> > Signed-off-by: Jiri Kosina <jkosina@suse.cz>
>
> Acked-by: Marcel Holtmann <marcel@holtmann.org>
>
> > - ret = sony_set_operational(hdev);
> > + if (hdev->bus == BUS_USB)
> > + ret = sony_set_operational(hdev);
> > + else if (hdev->bus == BUS_BLUETOOTH)
> > + ret = sony_set_operational_bt(hdev);
> > + else
> > + ret = 0;
> > +
>
> I would do sony_set_operational_usb() and sony_set_operational_bt() and
> also turn this into a switch statement for better readability.

Fixed and applied. Thanks,

--
Jiri Kosina
SUSE Labs, Novell Inc.