From: Vitaly Mayatskikh <v.mayatskih@gmail.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Vitaly Mayatskikh <v.mayatskih@gmail.com>,
Roland McGrath <roland@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: wait_task_zombie plus WNOWAIT question
Date: Wed, 01 Jul 2009 16:10:11 +0200 [thread overview]
Message-ID: <87d48kh4u4.wl%vmayatsk@redhat.com> (raw)
In-Reply-To: <20090701135544.GA24374@redhat.com>
At Wed, 1 Jul 2009 15:55:44 +0200, Oleg Nesterov wrote:
>
> On 07/01, Vitaly Mayatskikh wrote:
> >
> > I'm working on (sigh) next version of wait_task_* cleanups and stuck
> > in wait_task_zombie. I'm trying to move put_user(stat, wo->wo_stat)
> > code from all wait_task_* functions to common place, but
> > wait_task_zombie does not fill wo_stat if WNOWAIT flag is set
>
> Only waitid() can use WNOWAIT, and in this case ->wo_stat == NULL.
>
> > and does
> > it w/o that flag. Is it done so by design, or I can make
> > user-visible change and add put_user in WNOWAIT path?
>
> Just check do not do put_user(->wo_stat) if it is NULL in do_wait
> pathes.
Got it! Thanks, Oleg!
--
wbr, Vitaly
prev parent reply other threads:[~2009-07-01 14:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-01 13:41 wait_task_zombie plus WNOWAIT question Vitaly Mayatskikh
2009-07-01 13:55 ` Oleg Nesterov
2009-07-01 14:10 ` Vitaly Mayatskikh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d48kh4u4.wl%vmayatsk@redhat.com \
--to=v.mayatskih@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox