public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] get/set FAT filesystem attribute bits
Date: Tue, 04 Jan 2005 17:34:53 +0900	[thread overview]
Message-ID: <87d5wlmw2a.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <41D9B1C4.5050507@zytor.com> (H. Peter Anvin's message of "Mon, 03 Jan 2005 12:57:40 -0800")

"H. Peter Anvin" <hpa@zytor.com> writes:

> -	inode->i_ctime.tv_nsec = de->ctime_ms * 1000000;
> -	MSDOS_I(inode)->i_ctime_ms = de->ctime_ms;
> +	inode->i_ctime.tv_nsec = de->ctime_ms * 1000000U;

Actually, the ->ctime_ms is not mili seconds. The valid range is 0-199 (*10ms).
(And ->ctime is started from 2 seconds)

> -		raw_entry->ctime_ms = MSDOS_I(inode)->i_ctime_ms; /* use i_ctime.tv_nsec? */
> +		raw_entry->ctime_ms = inode->i_ctime.tv_nsec / 1000000U;

Ditto


BTW, do you already have any plan to use this ioctls?

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

  parent reply	other threads:[~2005-01-04  8:35 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-03 20:57 [PATCH] get/set FAT filesystem attribute bits H. Peter Anvin
2005-01-03 21:24 ` Nicholas Miell
2005-01-03 21:35   ` H. Peter Anvin
2005-01-03 21:46     ` Nicholas Miell
2005-01-03 22:02       ` H. Peter Anvin
2005-01-03 22:10         ` Nicholas Miell
2005-01-03 22:25           ` H. Peter Anvin
2005-01-03 23:16             ` Nicholas Miell
2005-01-03 23:22               ` H. Peter Anvin
2005-01-03 23:46                 ` Nicholas Miell
2005-01-04 10:09         ` Anton Altaparmakov
2005-01-04 21:45           ` Nicholas Miell
2005-01-04  8:34 ` OGAWA Hirofumi [this message]
2005-01-04  9:41   ` H. Peter Anvin
     [not found] <fa.ea9o20r.kje5qn@ifi.uio.no>
     [not found] ` <fa.lub44op.a2ec2d@ifi.uio.no>
2005-01-04 11:57   ` Bodo Eggert
2005-01-04 21:26     ` H. Peter Anvin
     [not found] <fa.i537e7s.1d6m90c@ifi.uio.no>
     [not found] ` <fa.ihdqkec.1i5umji@ifi.uio.no>
2005-01-06  0:07   ` Bodo Eggert
2005-01-06  1:35     ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d5wlmw2a.fsf@devron.myhome.or.jp \
    --to=hirofumi@mail.parknet.co.jp \
    --cc=akpm@osdl.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox