From: Gerd Knorr <kraxel@bytesex.org>
To: Andreas Dilger <adilger@clusterfs.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: RFC: Testing for kernel features in external modules
Date: 24 Jun 2004 23:07:45 +0200 [thread overview]
Message-ID: <87d63ois0u.fsf@bytesex.org> (raw)
In-Reply-To: <20040624203516.GV31203@schnapps.adilger.int>
Andreas Dilger <adilger@clusterfs.com> writes:
> Ideally, when people make an incompatible kernel API change like this
> they would just #define HAVE_REMAP_PAGE_RANGE_VMA in the header that
> declares remap_page_range() directly (e.g. KERNEL_AS_O_DIRECT was added
> for this reason) instead of external builds having to figure this out
> themselves. Adding the check script is no less work than just adding
> the #define to the appropriate header directly.
I fully agree here, just having #defines for kernel features (which
can't be detected otherwise) is much easier.
Ge- "#define HAVE_V4L2 1" rd
--
2004-06-24: Switched mail/news setup to a new machine. If something
is unusual/strange/broken/whatever feel free to drop me a note.
=> kraxel@bytesex.org
next prev parent reply other threads:[~2004-06-24 21:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-24 20:30 RFC: Testing for kernel features in external modules Sam Ravnborg
2004-06-24 20:24 ` Patrick McFarland
2004-06-24 20:49 ` Sam Ravnborg
2004-06-24 20:35 ` Andreas Dilger
2004-06-24 21:07 ` Gerd Knorr [this message]
2004-06-24 21:23 ` Sam Ravnborg
2004-06-25 8:32 ` Andreas Gruenbacher
2004-06-25 9:04 ` Lars Marowsky-Bree
2004-06-26 23:48 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d63ois0u.fsf@bytesex.org \
--to=kraxel@bytesex.org \
--cc=adilger@clusterfs.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox