From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Albert Cahalan <albert@users.sourceforge.net>
Cc: linux-kernel mailing list <linux-kernel@vger.kernel.org>,
areiter@preventsys.com, rmk+serial@arm.linux.org.uk,
tytso@mit.edu
Subject: Re: Subject: Re: NULL pointer in proc_pid_stat -- oops.
Date: Mon, 29 Mar 2004 23:18:47 +0900 [thread overview]
Message-ID: <87d66vd9dk.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <1080524145.2233.1877.camel@cube>
Albert Cahalan <albert@users.sf.net> writes:
> > if (task->tty) {
> > tty_pgrp = task->tty->pgrp;
> > tty_nr = new_encode_dev(tty_devnum(task->tty));
> > }
> >
> > Some place doesn't take the any lock for ->tty.
> > I think we need to take the lock for ->tty.
>
> Probably this isn't the thing for 2.6.xx,
Ah, sorry for confusing. This is 2.6.x (maybe also 2.4.x).
e.g. the above take the task_lock(). But disassociate_ctty() just take
read_lock(&tasklist_lock), etc. etc. So looks like racy.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2004-03-29 14:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-29 1:35 Subject: Re: NULL pointer in proc_pid_stat -- oops Albert Cahalan
2004-03-29 14:18 ` OGAWA Hirofumi [this message]
2004-03-29 17:09 ` Ricky Beam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d66vd9dk.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=albert@users.sourceforge.net \
--cc=areiter@preventsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+serial@arm.linux.org.uk \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox