public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alex Tomas <bzzz@tmi.comex.ru>
To: linux-kernel@vger.kernel.org
Cc: ext2-devel@lists.sourceforge.net, Alex Tomas <bzzz@tmi.comex.ru>
Subject: [RFC] probably bug in current ext3/jbd
Date: Sun, 18 May 2003 17:21:08 +0000	[thread overview]
Message-ID: <87d6igmarf.fsf@gw.home.net> (raw)


hi!

ext3/jbd use b_committed_data buffer in order to prevent
allocation of blocks which were freed in non-committed
transaction. I think there is bug in this code. look,

some thread                               commit thread
----------------------------------------------------------
get_undo_access(#1)
dirty_buffer(#1)
stop_journal()

                                           start commit


start_journal()
get_undo_access(#1):
   1) wait for #1 to be
      in t_forget_list

                                           write #1 to log
                                           put #1 onto t_forget_list


   2) b_commit_data exists,
      finish get_undo_access()


                                           for_each_bh_in_forget_list() {
                                              if (jh->b_committed_data) {
                                                  kfree(jh->b_committed_data);
                                                  jh->b_committed_data = NULL;
                                              }
                                           }

                                           
/* using of b_committed_data */

b_committed_data is NULL ?



with best regards, Alex


             reply	other threads:[~2003-05-18 13:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-18 17:21 Alex Tomas [this message]
2003-05-19 20:34 ` [Ext2-devel] [RFC] probably bug in current ext3/jbd Stephen C. Tweedie
2003-05-20  0:46   ` Alex Tomas
2003-05-19 20:51     ` Stephen C. Tweedie
2003-05-20  0:58       ` Alex Tomas
2003-05-20 16:06       ` Alex Tomas
2003-05-21 16:38         ` Andrew Morton
2003-05-21 20:45           ` Alex Tomas
2003-05-21 16:59             ` Andrew Morton
     [not found]               ` <m3brxwe2lr.fsf@lexa.home.net>
     [not found]                 ` <20030521103737.52eddeb3.akpm@digeo.com>
     [not found]                   ` <87n0hgc6s6.fsf@gw.home.net>
     [not found]                     ` <20030521105011.2d316baf.akpm@digeo.com>
     [not found]                       ` <87k7ckc5z2.fsf@gw.home.net>
     [not found]                         ` <20030521143140.3aaa86ba.akpm@digeo.com>
2003-05-23 11:08                           ` Alex Tomas
2003-05-23  8:49                             ` Andrew Morton
2003-05-23 12:49                               ` Alex Tomas
2003-05-23 11:20           ` [RFC] probably invalid accounting in jbd Alex Tomas
2003-05-23  8:26             ` Andrew Morton
2003-05-23 16:02               ` [Ext2-devel] " Andreas Dilger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d6igmarf.fsf@gw.home.net \
    --to=bzzz@tmi.comex.ru \
    --cc=ext2-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox