From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dan Carpenter <dan.carpenter@linaro.org>,
Lars Poeschel <poeschel@lemonage.de>
Cc: Paolo Abeni <pabeni@redhat.com>,
Aleksandr Mishin <amishin@t-argos.ru>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] nfc: pn533: Delete an unnecessary check
Date: Wed, 13 Aug 2025 10:13:24 +0200 [thread overview]
Message-ID: <87d7c789-0872-4d6b-9ef2-db3543f1d295@kernel.org> (raw)
In-Reply-To: <aJwn2ox5g9WsD2Vx@stanley.mountain>
On 13/08/2025 07:51, Dan Carpenter wrote:
> The "rc" variable is set like this:
>
> if (IS_ERR(resp)) {
> rc = PTR_ERR(resp);
>
> We know that "rc" is negative so there is no need to check.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/nfc/pn533/pn533.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-08-13 8:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 5:51 [PATCH net-next] nfc: pn533: Delete an unnecessary check Dan Carpenter
2025-08-13 8:13 ` Krzysztof Kozlowski [this message]
2025-08-15 0:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d7c789-0872-4d6b-9ef2-db3543f1d295@kernel.org \
--to=krzk@kernel.org \
--cc=amishin@t-argos.ru \
--cc=dan.carpenter@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=poeschel@lemonage.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).