From: Jiri Slaby <jirislaby@kernel.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
linux-serial@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Johan Hovold" <johan@kernel.org>,
"Samuel Iglesias Gonsálvez" <siglesias@igalia.com>,
"Rodolfo Giometti" <giometti@enneenne.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 12/13] tty: moxa: Rename dtr/rts parameters/variables to active
Date: Wed, 11 Jan 2023 06:59:13 +0100 [thread overview]
Message-ID: <87dd3dc8-5ac5-1647-cd31-25f2e197e1a8@kernel.org> (raw)
In-Reply-To: <20230110120226.14972-13-ilpo.jarvinen@linux.intel.com>
On 10. 01. 23, 13:02, Ilpo Järvinen wrote:
> Use active consistently for naming parameters and variables.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
> --- a/drivers/tty/moxa.c
> +++ b/drivers/tty/moxa.c
...
> @@ -1881,10 +1881,10 @@ static void MoxaPortFlushData(struct moxa_port *port, int mode)
> * Syntax:
> * int MoxaPortGetLineOut(int port, int *dtrState, int *rtsState);
Hmm, this is wrong too ^^. Not sure what introduced the problem.
> * int port : port number (0 - 127)
> - * bool * dtrState : pointer to bool to receive the current DTR
> + * bool * dtr_active : pointer to bool to receive the current DTR
> * state. (if NULL, this function will not
> * write to this address)
> - * bool * rtsState : pointer to bool to receive the current RTS
> + * bool * rts_active : pointer to bool to receive the current RTS
> * state. (if NULL, this function will not
> * write to this address)
> *
--
js
suse labs
next prev parent reply other threads:[~2023-01-11 5:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 12:02 [PATCH v2 00/13] tty/serial: bool conversions and cleanups Ilpo Järvinen
2023-01-10 12:02 ` [PATCH v2 01/13] tty: Cleanup tty_port_set_initialized() bool parameter Ilpo Järvinen
2023-01-10 12:02 ` [PATCH v2 02/13] tty: Cleamup tty_port_set_suspended() " Ilpo Järvinen
2023-01-10 12:02 ` [PATCH v2 03/13] tty: Cleanup tty_port_set_active() " Ilpo Järvinen
2023-01-10 12:02 ` [PATCH v2 04/13] tty: moxa: Make local var storing tty_port_initialized() bool Ilpo Järvinen
2023-01-10 12:02 ` [PATCH v2 05/13] serial: Convert uart_{,port_}startup() init_hw param to bool Ilpo Järvinen
2023-01-11 5:53 ` Jiri Slaby
2023-01-10 12:02 ` [PATCH v2 06/13] tty: Convert ->carrier_raised() and callchains " Ilpo Järvinen
2023-01-10 12:02 ` [PATCH v2 07/13] tty: Convert ->dtr_rts() to take bool argument Ilpo Järvinen
2023-01-10 12:02 ` [PATCH v2 08/13] tty/serial: Make ->dcd_change()+uart_handle_dcd_change() status bool active Ilpo Järvinen
2023-01-10 12:02 ` [PATCH v2 09/13] serial: Make uart_handle_cts_change() status param " Ilpo Järvinen
2023-01-11 5:54 ` Jiri Slaby
2023-01-10 12:02 ` [PATCH v2 10/13] tty: Return bool from tty_termios_hw_change() Ilpo Järvinen
2023-01-11 5:55 ` Jiri Slaby
2023-01-10 12:02 ` [PATCH v2 11/13] tty/serial: Call ->dtr_rts() parameter active consistently Ilpo Järvinen
2023-01-11 5:56 ` Jiri Slaby
2023-01-10 12:02 ` [PATCH v2 12/13] tty: moxa: Rename dtr/rts parameters/variables to active Ilpo Järvinen
2023-01-11 5:59 ` Jiri Slaby [this message]
2023-01-10 12:02 ` [PATCH v2 13/13] usb/serial: " Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87dd3dc8-5ac5-1647-cd31-25f2e197e1a8@kernel.org \
--to=jirislaby@kernel.org \
--cc=giometti@enneenne.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=siglesias@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox