The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Vitaliy Sochnev <sochnev.v.74@gmail.com>
Cc: Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	 Mikhail Zhilkin <csharper2005@gmail.com>
Subject: Re: [PATCH] mtd: spinand: confirm ready state on SkyHigh S35ML chips
Date: Mon, 16 Nov 2026 15:17:28 +0100	[thread overview]
Message-ID: <87eccksvwn.fsf@bootlin.com> (raw)
In-Reply-To: <20261030203342.91172-1-sochnev.v.74@gmail.com> (Vitaliy Sochnev's message of "Fri, 30 Oct 2026 22:33:42 +0200")

Hi Vitaliy,

Thanks for the patch.

On 30/10/2026 at 22:33:42 +02, Vitaliy Sochnev <sochnev.v.74@gmail.com> wrote:

> On a Nokia XG-040G-MD with a SkyHigh 256 MiB SPI-NAND, UBI reports
> fixable bit-flips during rootfs mount without this workaround:
>
>   ubi0: fixable bit-flip detected at PEB 1979
>   ubi0: schedule PEB 1979 for scrubbing
>   ubi0: scrubbed PEB 1979 (LEB 5:53), data moved to PEB 645
>
> Other reboots also report fixable bit-flips. A tester reports that after
> applying the workaround, sysupgrade, multiple reboots and an active
> workload produced no such warnings. Long-term operation is unverified.
>
> spinand_wait() accepts a single non-busy status sample. On these chips,
> the ready bit can briefly clear before the device is actually ready,
> allowing a premature cache read or a new program/erase command. The
> fallback status read for controllers with poll_status offload does not
> provide a second ready confirmation in the usual case.
>
> Mark the affected SkyHigh parts with a quirk and require a second ready
> status sample after spinand_wait() for those parts. If the chip becomes
> busy again, repeat the wait while the outer timeout has not elapsed.
> Each inner wait has its own timeout, so the quirk can wait up to roughly
> twice as long. Leave other SPI-NAND parts unchanged.

Can you give actual numbers? Can you log (without tracing) on multiple
attempts the state the device is reporting, as well as the read
timestamps? Could increasing RESET_INITIAL_DELAY_US slightly do the
trick?

Thanks,
Miquèl

      reply	other threads:[~2026-11-16 14:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-30 20:33 [PATCH] mtd: spinand: confirm ready state on SkyHigh S35ML chips Vitaliy Sochnev
2026-11-16 14:17 ` Miquel Raynal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eccksvwn.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=csharper2005@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    --cc=sochnev.v.74@gmail.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox