From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73E213D25DE for ; Mon, 15 Jun 2026 09:11:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781514676; cv=none; b=f4nrEZCiV5UFyaEIazcKecPcgGnZbSWZKyMqczW5hpnnS5Q3uwTdHTzKWeZX1O1kcObVRU+lrp4Kh9cDIb00T89bo/7Rmm1/Eq4yt9kKn/sgfr2wltY7gAb3mlVy3msfsue4FzejOiBsbdsaPNz1PZBw2s1aDPKTuMIVpE8QvMc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781514676; c=relaxed/simple; bh=N4/tg+X2k/P0MmWTP6eCYwMtX2GQOhJLczwSrjQ4Vl4=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=Nr85x1tUwXgTYmX43UEt9dBjETER1vrbIXxn62HbK3VB1UEOi+kY1ZF1PvGvsW8zv+hRg0csGRedRX+PbXChjVEblX2ee5ddqx5wJwbHEmDVBgTBqgJeWl74LOS7OEVQDwx5SQekUvk6LwIshGNi+dl8HX9fCJUgOC2LdeLGy6c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HI91eRal; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HI91eRal" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C749B1F000E9; Mon, 15 Jun 2026 09:11:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781514672; bh=+wsQIp/Tede8SSMcu4ufL/+FF0+UqEU/pYXt0tgN6u0=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=HI91eRalPyE3kgK0fsypPOg9LhdFcA85rte5BFjLjF2pf+Ri/hPOekQ0yhPUkllSZ JS9fyxmkJNIGrXGTxhEB7eRCD4aX9jThBEosq6/70P840Q8MtKRPQelLhLQx7y0zEe /idoe0rBej4bMmgJhn80rg2OZOB0EtSxV673T82mUwEFefXnkyk1libOD/Rm30M+2W y3H8disr0+jFTIcBNcQ/HOt6B4zamg8k6A1bcXd7v8K/B2e405Mdm+Kr5WbgaPhfa1 vuzLuRuYyTQ6xE2fE1lV/w5lw8u7oZmlDg7C2uOplF2vef3H5xu2eXYN37AohE+6r1 oGebGe9DviteQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=lobster-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wZ3La-0000000CsCL-1JmB; Mon, 15 Jun 2026 09:11:10 +0000 Date: Mon, 15 Jun 2026 10:14:27 +0100 Message-ID: <87eci888ss.wl-maz@kernel.org> From: Marc Zyngier To: Kemeng Shi Cc: tglx@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/6] irqchip/gic-v3-its: some minor cleanups In-Reply-To: <20260615032910.54735-7-shikemeng@huaweicloud.com> References: <20260615032910.54735-1-shikemeng@huaweicloud.com> <20260615032910.54735-7-shikemeng@huaweicloud.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: shikemeng@huaweicloud.com, tglx@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Mon, 15 Jun 2026 04:29:10 +0100, Kemeng Shi wrote: > > 1. Remove unneeded NULL check in itt_alloc_pool() as addr will always be > NULL when we reach here. > 2. Correct indentation in cpumask_pick_least_loaded() > 3. Remove unneeded updation of range node when it is to be deleted in > alloc_lpi_range(). > 4. Remove unneeded assignment to baser->psz which is already used > as input inits_setup_baser() Honestly, these changes, aside from (maybe) the last one, are pretty pointless. I'm sure there are better things to waste your time on. M. -- Jazz isn't dead. It just smells funny.