From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C64B22DEA98 for ; Tue, 24 Mar 2026 19:24:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774380242; cv=none; b=jCAlswGtjdYxmYRUd106bR/GqvSytwGZeHZ6F0IrDCCk7Ac65Sfv9bCToJJu8z+9ResLDMBCrWcsf4clOC5baq/kUDJaUlfgIQa0d85pmWr857l0U0IeMbZB/SEXTEv3K84Bza8vahlautH1UzlHtmTU1aZfKlcFAbXuhtTP49k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774380242; c=relaxed/simple; bh=COYTcvWMtZbNgmReV5I4uKrhM4N+yMIz+yCn9rIkSMk=; h=References:From:To:Cc:Subject:Date:In-reply-to:Message-ID: MIME-Version:Content-Type; b=hp4McaXBtACSz1oDo+MS3TfpSu+Yq5qgvkve+q6RgrzQYfJFPh1/LfwQKxuMX9pZz9dR7cAj5gG5QLEuIBI2RDuAMr8E5QfmnL0/BWvnTYGh/S8s6PO97dDmUVHzJ9Ztyt/dKdEpXB02MRjmP97Jh3eRY4mIzVfu1olR/CHION4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TwjKFrZS; arc=none smtp.client-ip=209.85.208.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TwjKFrZS" Received: by mail-lj1-f169.google.com with SMTP id 38308e7fff4ca-38a2e62b893so12650281fa.1 for ; Tue, 24 Mar 2026 12:24:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774380239; x=1774985039; darn=vger.kernel.org; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=wYMnchnB/TeeKyI/1Ye/NWdU8u0hSMm+QUE/z4pDCe4=; b=TwjKFrZSlyUK1FobEQN7cAIIAQNMn3ihFEfsUPWzvMuFbkuiQj6QmLVtJRP/TMyp5u 6oRwV3NKEyRyi3zwBPA/XFxG+T8k0Xga6BxsQVRP2AVIZdE8aQhByu0q2vmrUKLSOD6e mrnyie9HnsmajcEwQHdW25P1TIcvOeB2rYcZE75Semj2UDAcFn6wcCKNvVcW/XYhuGNS sOLdVU7QiEm4s4Ig+Bjnza+bv62Bd5gJOEbGt7Y4ItuYSPFxuoN63KEmL6slTGS8e0jf BHYztSNeaWhC7RaarcHnKuMlD+sIH1WKd0dBZp4w/En7D2st8jGYyI/8ZnBuSc2vVmJe HcxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774380239; x=1774985039; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=wYMnchnB/TeeKyI/1Ye/NWdU8u0hSMm+QUE/z4pDCe4=; b=OpRchDES2hMYddwHzsLGoDwsC0RiR9oYGmssQj073Z+rA7k4YiYhfsyESbS8iFoCmQ 59MjRjdlxTnpHaKtfxbEChqCFCJLZaZB/LoQfVvPovYIfzuiQl8eqhabwaQICZr0qTnr 9YqWwS8hh9aoGuyQaUrnv5LIapueHhfezzcHMKRUAxc9UKECfyS+rom2hljG1Ci1MbGd OcqRlNl3qdK69afqQPJuUMEV2eKNNu9W00mHthHqdU86A9WKArNOYhCH7hNtQP8vNuF5 xo57NnTZODAYnWmWg0h1Lhk8sNbf52vSRIXo0mwze8RjWVVJF2mqCWZzwTPntOG5gL5B LKOg== X-Forwarded-Encrypted: i=1; AJvYcCVoKaF/hGiSYFTEXEMD9zJfVNOQAzt89T38ZQKprTr1x8f6fUJsCqEtW6IkA8aGuVYtvwc47iFdVAWCEpo=@vger.kernel.org X-Gm-Message-State: AOJu0YxtTOTL980GrAkNzbB38nr/ESuD/1q0jHoC4RMTq0UCwjTL8vr0 AErmgxQUCIagg0VHjvXLQjfxn4cw6jGZQbgYRo4V865kac5CGz9HE5+/ X-Gm-Gg: ATEYQzxnXM4Hj6bQTqT5t5P3VXYztmXglB/prGKDiAl1aZd7RONgW+eoD6Jh4N9vAW3 jRnbzJDmZqKooEQWRKcMVEjpzY3570CQqss6YTNfGfjUa6ekLMGFKR26py4Sxg7edFi+2XZ9u/u +9PCaOabbw4tIKgDQ6xgtwoJcsap4APkhOK7eBi69Tl8pjHnoG9X3l7Y+ctFqFQRl3GvdJpOyTH 3TdT1Yq0TJLAl5qOYfxBdXj4Vo0FheRAUZ76F+TzMuzc55xjXT+gTcrURuEBUxviaZsR6GU3rhs tZjQ/0ZxAFsz8ipuOZ3cAT3jl1Y6EPE9AlBm+Rx2dT3WfAXrg3vuFs6YzQoJd7jVZpAg8oKhRQY UbOjeXT/tWq9ph/P2+FqGUC7Rz46/WAkVo/u1ZJ76UqLSIc1eEZDKawlbIFMDNtVivABc5xfeg8 rfpPSAPmQCinnjyehD8g8= X-Received: by 2002:a05:651c:4212:b0:38c:4231:91c2 with SMTP id 38308e7fff4ca-38c430c33d1mr1974511fa.10.1774380238610; Tue, 24 Mar 2026 12:23:58 -0700 (PDT) Received: from razdolb ([77.220.204.220]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38c34a2db0bsm6416851fa.21.2026.03.24.12.23.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 12:23:58 -0700 (PDT) References: <20250303-b4-rkisp-noncoherent-v4-0-e32e843fb6ef@gmail.com> User-agent: mu4e 1.10.9; emacs 30.2 From: Mikhail Rudenko To: Jacopo Mondi Cc: Dafna Hirschfeld , Laurent Pinchart , Mauro Carvalho Chehab , Heiko Stuebner , Tomasz Figa , Marek Szyprowski , Hans Verkuil , Sergey Senozhatsky , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , stable@vger.kernel.org Subject: Re: [PATCH v4 0/2] Allow non-coherent video capture buffers on Rockchip ISP V1 Date: Tue, 24 Mar 2026 22:12:33 +0300 In-reply-to: Message-ID: <87ecl9f2uv.fsf@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Hi, Jacopo! On 2026-03-23 at 17:03 +01, Jacopo Mondi wrote: > Hello > > On Mon, Mar 03, 2025 at 02:40:08PM +0300, Mikhail Rudenko wrote: >> This small series adds support for non-coherent video capture buffers >> on Rockchip ISP V1. Patch 1 fixes cache management for dmabuf's >> allocated by dma-contig allocator. Patch 2 allows non-coherent >> allocations on the rkisp1 capture queue. Some timing measurements are >> provided in the commit message of patch 2. >> >> Signed-off-by: Mikhail Rudenko > > I regularly get back to this series everytime I have to reason about > the caching policies in vb2.. > > Is there any reason why it didn't get in ? My impression is that all the review comments were addressed, but these patches somehow fell through the cracks. I can rebase and post v5 if any maintainer is interested in picking it up. >> --- >> Changes in v4: >> - rebase to media/next >> - use `direction` instead of `buf->dma_dir` in dma_sync_sgtable_* >> - Link to v3: https://lore.kernel.org/r/20250128-b4-rkisp-noncoherent-v3-0-baf39c997d2a@gmail.com >> >> Changes in v3: >> - ignore skip_cache_sync_* flags in vb2_dc_dmabuf_ops_{begin,end}_cpu_access >> - invalidate/flush kernel mappings as appropriate if they exist >> - use dma_sync_sgtable_* instead of dma_sync_sg_* >> - Link to v2: https://lore.kernel.org/r/20250115-b4-rkisp-noncoherent-v2-0-0853e1a24012@gmail.com >> >> Changes in v2: >> - Fix vb2_dc_dmabuf_ops_{begin,end}_cpu_access() for non-coherent buffers. >> - Add cache management timing information to patch 2 commit message. >> - Link to v1: https://lore.kernel.org/r/20250102-b4-rkisp-noncoherent-v1-1-bba164f7132c@gmail.com >> >> --- >> Mikhail Rudenko (2): >> media: videobuf2: Fix dmabuf cache sync/flush in dma-contig >> media: rkisp1: Allow non-coherent video capture buffers >> >> .../media/common/videobuf2/videobuf2-dma-contig.c | 22 ++++++++++++++++++++++ >> .../platform/rockchip/rkisp1/rkisp1-capture.c | 1 + >> 2 files changed, 23 insertions(+) >> --- >> base-commit: b2c4bf0c102084e77ed1b12090d77a76469a6814 >> change-id: 20241231-b4-rkisp-noncoherent-ad6e7c7a68ba >> >> Best regards, >> -- >> Mikhail Rudenko >> >> -- Best regards, Mikhail Rudenko