From: Takashi Iwai <tiwai@suse.de>
To: Soham Kute <officialsohamkute@gmail.com>
Cc: tiwai@suse.com, perex@perex.cz, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org,
syzbot+16b2b67ae905feb8a289@syzkaller.appspotmail.com
Subject: Re: [PATCH] ALSA: pcm: prevent snd_pcm_action after substream detach
Date: Mon, 09 Feb 2026 10:34:13 +0100 [thread overview]
Message-ID: <87ecmu2rca.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260208185340.8379-1-officialsohamkute@gmail.com>
On Sun, 08 Feb 2026 19:53:40 +0100,
Soham Kute wrote:
>
> syzbot reported a slab use-after-free in snd_pcm_post_stop() caused by
> snd_pcm_action() being invoked after snd_pcm_detach_substream() has
> already freed the PCM runtime.
>
> The previous approach attempted to guard against NULL runtime access in
> the post-action callback, which only masked the symptom. As pointed out
> in review, this does not address the underlying lifetime issue.
>
> Fix the root cause by preventing snd_pcm_action() from running once the
> substream runtime has been detached, ensuring that no PCM actions are
> executed after teardown.
>
> Reported-by: syzbot+16b2b67ae905feb8a289@syzkaller.appspotmail.com
>
> Signed-off-by: Soham Kute <officialsohamkute@gmail.com>
Thanks for the revised patch. This patch puts the check at a better
place than the previous patch, but it's still misleading; this doesn't
address the root cause at all. It's just plugging a hole at a middle
point of the code path.
I guess you're trying to fix the UAF report for aloop driver, and this
was already addressed by the recent patch (included in 6.19).
Please check whether you still see the problem with 6.19 release.
thanks,
Takashi
prev parent reply other threads:[~2026-02-09 9:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-08 18:53 [PATCH] ALSA: pcm: prevent snd_pcm_action after substream detach Soham Kute
2026-02-09 9:34 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ecmu2rca.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=officialsohamkute@gmail.com \
--cc=perex@perex.cz \
--cc=syzbot+16b2b67ae905feb8a289@syzkaller.appspotmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox