The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
Cc: Anna-Maria Behnsen <anna-maria@linutronix.de>,
	Frederic Weisbecker <frederic@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Juri Lelli <juri.lelli@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
	Valentin Schneider <vschneid@redhat.com>,
	Matt Wu <wuqiang.matt@bytedance.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Sean Young <sean@mess.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Jan Kiszka <jan.kiszka@siemens.com>,
	Kieran Bingham <kbingham@kernel.org>,
	linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org,
	linux-media@vger.kernel.org
Subject: Re: [PATCH 5/8] ALSA: hrtimer: Avoid direct access to hrtimer clockbase
Date: Tue, 12 Aug 2025 13:07:57 +0200	[thread overview]
Message-ID: <87ectgztki.wl-tiwai@suse.de> (raw)
In-Reply-To: <20250812-hrtimer-cleanup-get_time-v1-5-b962cd9d9385@linutronix.de>

On Tue, 12 Aug 2025 08:08:13 +0200,
Thomas Weißschuh wrote:
> 
> The field timer->base->get_time is a private implementation detail and
> should not be accessed outside of the hrtimer core.
> 
> Switch to the equivalent helper.
> 
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> ---
>  sound/core/hrtimer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/core/hrtimer.c b/sound/core/hrtimer.c
> index c364bd126ac8b311e3ce899e226ff9fd82c4485f..2d5f4d47071f79d7db24c8f004f0f4154808fdd8 100644
> --- a/sound/core/hrtimer.c
> +++ b/sound/core/hrtimer.c
> @@ -44,7 +44,7 @@ static enum hrtimer_restart snd_hrtimer_callback(struct hrtimer *hrt)
>  	}
>  
>  	/* calculate the drift */
> -	delta = ktime_sub(hrt->base->get_time(), hrtimer_get_expires(hrt));
> +	delta = ktime_sub(hrtimer_cb_get_time(hrt), hrtimer_get_expires(hrt));
>  	if (delta > 0)
>  		ticks += ktime_divns(delta, ticks * resolution);

Acked-by: Takashi Iwai <tiwai@suse.de>


thanks,

Takashi

  reply	other threads:[~2025-08-12 11:08 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-12  6:08 [PATCH 0/8] hrtimer: Remove hrtimer_clock_base::get_time Thomas Weißschuh
2025-08-12  6:08 ` [PATCH 1/8] posix-timers: Avoid direct access to hrtimer clockbase Thomas Weißschuh
2025-09-09  8:56   ` [tip: timers/core] " tip-bot2 for Thomas Weißschuh
2025-08-12  6:08 ` [PATCH 2/8] timers/itimer: " Thomas Weißschuh
2025-09-09  8:56   ` [tip: timers/core] " tip-bot2 for Thomas Weißschuh
2025-08-12  6:08 ` [PATCH 3/8] sched/core: " Thomas Weißschuh
2025-09-09  8:56   ` [tip: timers/core] " tip-bot2 for Thomas Weißschuh
2025-08-12  6:08 ` [PATCH 4/8] lib: test_objpool: " Thomas Weißschuh
2025-09-09  8:56   ` [tip: timers/core] " tip-bot2 for Thomas Weißschuh
2025-08-12  6:08 ` [PATCH 5/8] ALSA: hrtimer: " Thomas Weißschuh
2025-08-12 11:07   ` Takashi Iwai [this message]
2025-09-09  8:56   ` [tip: timers/core] " tip-bot2 for Thomas Weißschuh
2025-08-12  6:08 ` [PATCH 6/8] media: pwm-ir-tx: " Thomas Weißschuh
2025-08-12 12:06   ` Sean Young
2025-09-09  8:56   ` [tip: timers/core] " tip-bot2 for Thomas Weißschuh
2025-08-12  6:08 ` [PATCH 7/8] hrtimer: Use hrtimer_cb_get_time() helper Thomas Weißschuh
2025-09-09  8:56   ` [tip: timers/core] " tip-bot2 for Thomas Weißschuh
2025-08-12  6:08 ` [PATCH 8/8] hrtimer: Remove hrtimer_clock_base::get_time Thomas Weißschuh
2025-08-12  7:42   ` Peter Zijlstra
2025-08-12  7:51     ` Thomas Weißschuh
2025-09-09  8:56   ` [tip: timers/core] " tip-bot2 for Thomas Weißschuh
2025-08-12  7:43 ` [PATCH 0/8] " Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ectgztki.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=anna-maria@linutronix.de \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=frederic@kernel.org \
    --cc=jan.kiszka@siemens.com \
    --cc=juri.lelli@redhat.com \
    --cc=kbingham@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=perex@perex.cz \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=sean@mess.org \
    --cc=tglx@linutronix.de \
    --cc=thomas.weissschuh@linutronix.de \
    --cc=tiwai@suse.com \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    --cc=wuqiang.matt@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox