Re: [PATCH v4 1/2] clocksource: acpi_pm: Add external callback for suspend/resume

[Thomas Gleixner <tglx@linutronix.de>]

On Fri, Aug 09 2024 at 13:13, Marek Maslanka wrote:
> --- a/drivers/clocksource/acpi_pm.c
> +++ b/drivers/clocksource/acpi_pm.c
> @@ -25,6 +25,12 @@
>  #include <asm/io.h>
>  #include <asm/time.h>
>  
> +#include "acpi_pm.h"

include/linux/acpi_pmtmr.h please

> +static void *suspend_resume_cb_data;
> +
> +static void (*suspend_resume_callback)(void *data, bool suspend);
> +
>  /*
>   * The I/O port the PMTMR resides at.
>   * The location is detected during setup_arch(),
> @@ -58,6 +64,25 @@ u32 acpi_pm_read_verified(void)
>  	return v2;
>  }
>  
> +void acpi_pm_register_suspend_resume_callback(void (*cb)(void *data, bool suspend),
> +					      void *data)

No line break required. Also the name wants to be acpi_pmtmr_... for the
global visible function so that it can't be confused with the power
management related acpi_pm_* functions

Thanks,

        tglx