From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B2BC1E48B for ; Sat, 6 Apr 2024 09:58:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712397493; cv=none; b=qzdjss1/WskzQf/jmi01NhWqIGG8ijLUq7SP9Q9UjcGHZI3ZZ0Ej2gY+i6ExnNc1MSLoPoAVzyWa2FeQ0R7fz22TbevGyVFic6ECPnueEYFpHB5VeCwDwax/SniD4pUb5gD28n3tHAdaOVoxVuppwGVT2A8rTqtnytGY7p4AmiA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712397493; c=relaxed/simple; bh=8QOjyi5yo48Gc03G0D16O76wbrg04l+eAGY55tGyRSA=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=CSE+G2MV9jlQbvW1rNMhGI9kNS/FflZ8ksINKtqPD89d9zoOQkpD+2ZlCOtm9ElXUi94RvMO3komP0iaCcPOAi/uXhi5LhcicIQYlgZpivlhGRIjpaGbtIXU+MpjIHrXgliEVP5NaNDy83kg4yVWcDcdmMd+yPO10Z0z5eNmj+A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WCkKDUoA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WCkKDUoA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5980C433F1; Sat, 6 Apr 2024 09:58:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712397492; bh=8QOjyi5yo48Gc03G0D16O76wbrg04l+eAGY55tGyRSA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WCkKDUoAxS1hNUGaSvzPdz2OgUBAYcdgTIVhIbTpjTlKHpT4oiiTjTA0d/5hEjbIw SaDvW5m9P3E795ro7EQFODrYT5fjjj17ebXlda5cKDnqo+aWnKqFOz3HOUNfGlRXeO OPE46yAkQNN4By0DGlYpNVWjOAVaY9M6HOnVSSlQX4UFS82YQyVmX6jGgeeIvMNWTq hYBzpb2HrXqx9yZTmtrr0Xt/VldxNWneHQ6NGQOErVp99A7yR2HbvvUBwnxWXWruV2 5qErzfhTtLOjB4O0+3l4jqYe2nmFvSHN/J/uh+H6KVAedg1/uPzarykMkR8QkCdPrc +J38PgGCQEmmg== Received: from sofa.misterjones.org ([185.219.108.64] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rt2oM-0023Jb-Jp; Sat, 06 Apr 2024 10:58:10 +0100 Date: Sat, 06 Apr 2024 10:58:10 +0100 Message-ID: <87edbisthp.wl-maz@kernel.org> From: Marc Zyngier To: Nianyao Tang , Thomas Gleixner Cc: , , , , Subject: Re: [RESPIN PATCH] irqchip/gic-v4.1:Fix VSYNC referencing an unmapped VPE In-Reply-To: <20240406022737.3898763-1-tangnianyao@huawei.com> References: <20240406022737.3898763-1-tangnianyao@huawei.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: tangnianyao@huawei.com, tglx@linutronix.de, yuzenghui@huawei.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, guoyang2@huawei.com, wangwudi@hisilicon.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Sat, 06 Apr 2024 03:27:37 +0100, Nianyao Tang wrote: > > As per the GICv4.1 spec (Arm IHI 0069H, 5.3.19): > > "A VMAPP with {V, Alloc}=={0, x} is self-synchronizing, This means the > ITS command queue does not show the command as consumed until all of > its effects are completed." > > Furthermore, VSYNC is allowed to deliver an SError when referencing a > non existent VPE. > > By these definitions, a VMAPP followed by a VSYNC is a bug, as the > later references a VPE that has been unmapped by the former. > > Fix it by eliding the VSYNC in this scenario. > > Fixes: 64edfaa9a234 ("irqchip/gic-v4.1: Implement the v4.1 flavour of VMAPP") > > Signed-off-by: Nianyao Tang > Reviewed-by: Marc Zyngier Thanks for having taken my remarks into account, it looks good now. Thomas, can you please take this as a fix for 6.9? Thanks, M. -- Without deviation from the norm, progress is not possible.