From: Thomas Gleixner <tglx@linutronix.de>
To: Andi Kleen <ak@linux.intel.com>, x86@kernel.org
Cc: linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH v2] x86/mtrr: Check if fixed MTRRs exist before saving them
Date: Thu, 29 Feb 2024 00:26:26 +0100 [thread overview]
Message-ID: <87edcw8925.ffs@tglx> (raw)
In-Reply-To: <20240110150806.22531-1-ak@linux.intel.com>
On Wed, Jan 10 2024 at 07:08, Andi Kleen wrote:
> This one place forgot to check the fixed capability.
This one place forgot? And what the heck is a fixed capability?
> Otherwise there will a harmless but ugly WARN_ON for the failed WRMSR
> when the MSR doesn't exist.
This is not a sentence as it lacks a verb,
Also it does not matter whether you think that the WARN_ON() is ugly or
not. Can you please write a changelog in technical terms?
> Noticed when testing X86S support.
Who cares?
> Fixes: 2b1f6278d77c ("[PATCH] x86: Save the MTRRs of the BSP before")
This fixes tag is pointlessly truncated. The correct one is:
Fixes: 2b1f6278d77c ("[PATCH] x86: Save the MTRRs of the BSP before booting an AP")
It's not rocket science to copy & pasta correctly.
Thanks,
tglx
prev parent reply other threads:[~2024-02-28 23:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-10 15:08 [PATCH v2] x86/mtrr: Check if fixed MTRRs exist before saving them Andi Kleen
2024-02-28 16:52 ` Andi Kleen
2024-02-28 23:26 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edcw8925.ffs@tglx \
--to=tglx@linutronix.de \
--cc=ak@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox