From: John Ogness <john.ogness@linutronix.de>
To: Stephen Brennan <stephen.s.brennan@oracle.com>,
linux-kernel@vger.kernel.org
Cc: Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Stephen Brennan <stephen.s.brennan@oracle.com>
Subject: Re: [PATCH] printk: save loglevel before console_verbose()
Date: Fri, 16 Feb 2024 10:28:46 +0106 [thread overview]
Message-ID: <87eddcsqzd.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <20240216005128.1045812-1-stephen.s.brennan@oracle.com>
On 2024-02-15, Stephen Brennan <stephen.s.brennan@oracle.com> wrote:
> In panic() cases, console_verbose() is called, clobbering the
> console_loglevel value. If the bug which led to the panic related to
> printk, it can be useful to know the log level prior to the
> console_verbose() call.
I've done a *lot* of printk debugging over the past 6 years and have
never had a case where this would be useful (or even interesting).
I assume there is some rare and particular scenario you are trying to
debug. And once you've debugged it, it is no longer useful for you
either.
IMHO this does not warrant adding an extra global variable for all Linux
users.
When Petr gets back from vacation, maybe he will have a different
opinion.
John Ogness
next prev parent reply other threads:[~2024-02-16 9:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 0:51 [PATCH] printk: save loglevel before console_verbose() Stephen Brennan
2024-02-16 9:22 ` John Ogness [this message]
2024-02-16 16:02 ` Stephen Brennan
2024-02-27 16:39 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eddcsqzd.fsf@jogness.linutronix.de \
--to=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=stephen.s.brennan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox