public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Ivan Orlov <ivan.orlov0322@gmail.com>
Cc: perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: core: Fix dependencies for SND_CORE_TEST
Date: Thu, 01 Feb 2024 14:05:04 +0100	[thread overview]
Message-ID: <87eddwz667.wl-tiwai@suse.de> (raw)
In-Reply-To: <20240201094604.1347793-1-ivan.orlov0322@gmail.com>

On Thu, 01 Feb 2024 10:46:04 +0100,
Ivan Orlov wrote:
> 
> Add the CONFIG_SND_PCM dependency for CONFIG_SND_CORE_TEST config entry
> as the test uses symbols from 'pcm_misc.c'.
> 
> Signed-off-by: Ivan Orlov <ivan.orlov0322@gmail.com>

It should rather select instead of depends-on.  User can't enable
CONFIG_SND_PCM explicitly, but it's selected by the top-level
drivers.

Also, please add Fixes tag.  It's a clear regression fix.


thanks,

Takashi

  reply	other threads:[~2024-02-01 13:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-01  9:46 [PATCH] ALSA: core: Fix dependencies for SND_CORE_TEST Ivan Orlov
2024-02-01 13:05 ` Takashi Iwai [this message]
2024-02-01 21:48   ` Ivan Orlov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eddwz667.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=ivan.orlov0322@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox