* [PATCH] gma500: Clean up errors in psb_intel_sdvo_regs.h
@ 2024-01-11 7:07 GuoHua Chen
2024-01-11 9:49 ` Jani Nikula
0 siblings, 1 reply; 2+ messages in thread
From: GuoHua Chen @ 2024-01-11 7:07 UTC (permalink / raw)
To: tzimmermann, airlied, maarten.lankhorst, daniel, mripard,
patrik.r.jakobsson
Cc: linux-kernel, dri-devel, GuoHua Chen
Fix the following errors reported by checkpatch:
ERROR: space required after that close brace '}'
Signed-off-by: GuoHua Chen <chenguohua_716@163.com>
---
drivers/gpu/drm/gma500/psb_intel_sdvo_regs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/gma500/psb_intel_sdvo_regs.h b/drivers/gpu/drm/gma500/psb_intel_sdvo_regs.h
index 600e79744d68..e358a6b1bcce 100644
--- a/drivers/gpu/drm/gma500/psb_intel_sdvo_regs.h
+++ b/drivers/gpu/drm/gma500/psb_intel_sdvo_regs.h
@@ -666,7 +666,7 @@ struct psb_intel_sdvo_enhancement_limits_reply {
#define SDVO_CMD_SET_TV_LUMA_FILTER 0x79
struct psb_intel_sdvo_enhancements_arg {
u16 value;
-}__attribute__((packed));
+} __attribute__((packed));
#define SDVO_CMD_GET_DOT_CRAWL 0x70
#define SDVO_CMD_SET_DOT_CRAWL 0x71
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] gma500: Clean up errors in psb_intel_sdvo_regs.h
2024-01-11 7:07 [PATCH] gma500: Clean up errors in psb_intel_sdvo_regs.h GuoHua Chen
@ 2024-01-11 9:49 ` Jani Nikula
0 siblings, 0 replies; 2+ messages in thread
From: Jani Nikula @ 2024-01-11 9:49 UTC (permalink / raw)
To: GuoHua Chen, tzimmermann, airlied, maarten.lankhorst, daniel,
mripard, patrik.r.jakobsson
Cc: linux-kernel, dri-devel, GuoHua Chen
On Thu, 11 Jan 2024, GuoHua Chen <chenguohua_716@163.com> wrote:
> Fix the following errors reported by checkpatch:
>
> ERROR: space required after that close brace '}'
>
> Signed-off-by: GuoHua Chen <chenguohua_716@163.com>
> ---
> drivers/gpu/drm/gma500/psb_intel_sdvo_regs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/gma500/psb_intel_sdvo_regs.h b/drivers/gpu/drm/gma500/psb_intel_sdvo_regs.h
> index 600e79744d68..e358a6b1bcce 100644
> --- a/drivers/gpu/drm/gma500/psb_intel_sdvo_regs.h
> +++ b/drivers/gpu/drm/gma500/psb_intel_sdvo_regs.h
> @@ -666,7 +666,7 @@ struct psb_intel_sdvo_enhancement_limits_reply {
> #define SDVO_CMD_SET_TV_LUMA_FILTER 0x79
> struct psb_intel_sdvo_enhancements_arg {
> u16 value;
> -}__attribute__((packed));
> +} __attribute__((packed));
__packed is preferred over __attribute__((packed)) anyway...
BR,
Jani.
>
> #define SDVO_CMD_GET_DOT_CRAWL 0x70
> #define SDVO_CMD_SET_DOT_CRAWL 0x71
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-01-11 9:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-11 7:07 [PATCH] gma500: Clean up errors in psb_intel_sdvo_regs.h GuoHua Chen
2024-01-11 9:49 ` Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox