From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3318CC4167B for ; Thu, 7 Dec 2023 07:43:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377980AbjLGHnA (ORCPT ); Thu, 7 Dec 2023 02:43:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377638AbjLGHm6 (ORCPT ); Thu, 7 Dec 2023 02:42:58 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D15A4D44 for ; Wed, 6 Dec 2023 23:43:04 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 634B4C433C8; Thu, 7 Dec 2023 07:43:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701934984; bh=30lIgOBu7d++7DZC1ye4cv89/NsSn5HlsRgMNBse8Aw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=deqaXyy+jcN41IxCjYsashS/h8Lp8ZiH5epFSO41aYVMRswCRhrW2GO5pd3C4xG+m bJCJ/b883QBBheLZd7b0UEOwHzWVC8N7fQkw6LAgTpPW69cCrnfCQqwPSzErmIXlqz l83moJda7/hWut9dfh4PZqRXman5eidgZnaG8QozvE0hGNv6k17uONW/oSQ5K/RVDw bQMApKxj7S0/lW/EQ8j8bZhFMTt5WtYS5bG0wMCQFAGKDrE4/FCwkL/h5DxgBuRrEs gksxW7q+Q5P3o8Vkv11cykjnvPUMrkRNsS/axm1HO3iW67Y4DX/HIKXwVl/2tPIf0K cIaLGHjogVN6A== Received: from ip-185-104-136-29.ptr.icomera.net ([185.104.136.29] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rB92D-0028Sq-RP; Thu, 07 Dec 2023 07:43:02 +0000 Date: Thu, 07 Dec 2023 07:43:04 +0000 Message-ID: <87edfy8nlj.wl-maz@kernel.org> From: Marc Zyngier To: Mukesh Ojha Cc: , , Subject: Re: [PATCH] irqchip/gic-v3-its: BUG_ON if stall bit is set In-Reply-To: <1701929559-18252-1-git-send-email-quic_mojha@quicinc.com> References: <1701929559-18252-1-git-send-email-quic_mojha@quicinc.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.104.136.29 X-SA-Exim-Rcpt-To: quic_mojha@quicinc.com, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 07 Dec 2023 06:12:39 +0000, Mukesh Ojha wrote: > > There could be various reason that stall bit could > be set due to software errors while processing > commands in command queue is being processed and Such as? > waiting for 1s is not going to help in debugging > as command processing anyways going to be timed > out and system will continue to run and may crash > after some time due to this. > > So, to debug such issues what command caused the > stall bit to set, BUG_ON right away. How on Earth will killing the system allow *anything* to be further debugged? If you need debug information, add the correct debug statements using pr_debug(). Even better, try to gracefully recover from it if the ITS command queue supports restarting. Crashing the system is not an option. M. -- Without deviation from the norm, progress is not possible.