public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: "Jiqian Chen" <Jiqian.Chen@amd.com>,
	"Juergen Gross" <jgross@suse.com>,
	"Stefano Stabellini" <sstabellini@kernel.org>,
	"Oleksandr Tyshchenko" <oleksandr_tyshchenko@epam.com>,
	"Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	"Len Brown" <lenb@kernel.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Roger Pau Monné" <roger.pau@citrix.com>,
	xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
	linux-acpi@vger.kernel.org
Cc: Stefano Stabellini <stefano.stabellini@amd.com>,
	Alex Deucher <Alexander.Deucher@amd.com>,
	Christian Koenig <Christian.Koenig@amd.com>,
	Stewart Hildebrand <Stewart.Hildebrand@amd.com>,
	Xenia Ragiadakou <xenia.ragiadakou@amd.com>,
	Honglei Huang <Honglei1.Huang@amd.com>,
	Julia Zhang <Julia.Zhang@amd.com>, Huang Rui <Ray.Huang@amd.com>,
	Jiqian Chen <Jiqian.Chen@amd.com>, Huang Rui <ray.huang@amd.com>
Subject: Re: [RFC KERNEL PATCH v2 1/3] xen/pci: Add xen_reset_device_state function
Date: Mon, 04 Dec 2023 08:58:22 +0100	[thread overview]
Message-ID: <87edg2xuu9.ffs@tglx> (raw)
In-Reply-To: <20231124103123.3263471-2-Jiqian.Chen@amd.com>

On Fri, Nov 24 2023 at 18:31, Jiqian Chen wrote:
> When device on dom0 side has been reset, the vpci on Xen side
> won't get notification, so that the cached state in vpci is
> all out of date with the real device state.
> To solve that problem, this patch add a function to clear all

Please get rid of 'this patch' all over the series.

# grep -r 'This patch' Documentation/process/

> vpci device state when device is reset on dom0 side.
>
> And call that function in pcistub_init_device. Because when
> we use "pci-assignable-add" to assign a passthrough device in
> Xen, it will reset passthrough device and the vpci state will
> out of date, and then device will fail to restore bar state.
>
> Signed-off-by: Jiqian Chen <Jiqian.Chen@amd.com>
> Signed-off-by: Huang Rui <ray.huang@amd.com>

This Signed-off-by chain is incorrect.

Documentation/process/submitting-patches.rst has a full chapter about
S-O-B and the correct usage.

Thanks,

        tglx

  parent reply	other threads:[~2023-12-04  7:58 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-24 10:31 [RFC KERNEL PATCH v2 0/3] Support device passthrough when dom0 is PVH on Xen Jiqian Chen
2023-11-24 10:31 ` [RFC KERNEL PATCH v2 1/3] xen/pci: Add xen_reset_device_state function Jiqian Chen
2023-11-30  3:46   ` Stefano Stabellini
2023-11-30  7:03     ` Chen, Jiqian
2023-11-30 15:03       ` Stewart Hildebrand
2023-12-04  3:25         ` Chen, Jiqian
2023-12-04  3:45           ` Stewart Hildebrand
2023-12-04  7:58   ` Thomas Gleixner [this message]
2023-12-04  8:49     ` Chen, Jiqian
2023-12-04 21:31       ` Stefano Stabellini
2023-12-05  6:50         ` Chen, Jiqian
2023-12-05 17:02         ` Thomas Gleixner
2023-12-06  6:37           ` Chen, Jiqian
2023-11-24 10:31 ` [RFC KERNEL PATCH v2 2/3] xen/pvh: Unmask irq for passthrough device in PVH dom0 Jiqian Chen
2023-11-30  3:53   ` Stefano Stabellini
2023-11-30 16:02     ` Roger Pau Monné
2023-12-01  3:15       ` Stefano Stabellini
2023-12-01  8:58         ` Roger Pau Monné
2023-12-02  3:37           ` Stefano Stabellini
2023-12-04 10:28             ` Roger Pau Monné
2023-12-04 22:19               ` Stefano Stabellini
2023-12-05  9:19                 ` Roger Pau Monné
2023-12-05  9:39                   ` Chen, Jiqian
2023-12-05 10:32                   ` Jan Beulich
2023-12-06  6:07                     ` Chen, Jiqian
2023-12-07  2:18                       ` Stefano Stabellini
2023-12-07  3:38                         ` Chen, Jiqian
2023-12-07  6:43                         ` Juergen Gross
2023-12-08  5:53                           ` Chen, Jiqian
2023-12-11 15:45                       ` Roger Pau Monné
2023-12-12  6:16                         ` Chen, Jiqian
2023-12-12  8:49                           ` Roger Pau Monné
2023-12-12  9:38                             ` Jan Beulich
2023-12-12 11:18                               ` Roger Pau Monné
2023-12-12 11:19                                 ` Jan Beulich
2023-12-12 11:39                                   ` Roger Pau Monné
2023-12-13  7:14                                     ` Chen, Jiqian
2023-12-13  7:41                                       ` Jan Beulich
2023-12-05  6:46               ` Chen, Jiqian
2023-12-04  8:13   ` Thomas Gleixner
2023-12-05  7:03     ` Chen, Jiqian
2023-11-24 10:31 ` [RFC KERNEL PATCH v2 3/3] xen/privcmd: Add new syscall to get gsi from irq Jiqian Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87edg2xuu9.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=Alexander.Deucher@amd.com \
    --cc=Christian.Koenig@amd.com \
    --cc=Honglei1.Huang@amd.com \
    --cc=Jiqian.Chen@amd.com \
    --cc=Julia.Zhang@amd.com \
    --cc=Ray.Huang@amd.com \
    --cc=Stewart.Hildebrand@amd.com \
    --cc=bhelgaas@google.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=jgross@suse.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleksandr_tyshchenko@epam.com \
    --cc=rafael@kernel.org \
    --cc=roger.pau@citrix.com \
    --cc=sstabellini@kernel.org \
    --cc=stefano.stabellini@amd.com \
    --cc=xen-devel@lists.xenproject.org \
    --cc=xenia.ragiadakou@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox