public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Saurabh Sengar <ssengar@linux.microsoft.com>,
	mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
	x86@kernel.org, hpa@zytor.com, luto@kernel.org,
	peterz@infradead.org, mikelley@microsoft.com,
	linux-kernel@vger.kernel.org
Cc: ssengar@linux.microsoft.com
Subject: Re: [PATCH] x86/numa: Add Devicetree support
Date: Thu, 24 Aug 2023 17:28:37 +0200	[thread overview]
Message-ID: <87edjscvdm.ffs@tglx> (raw)
In-Reply-To: <1687850882-22554-1-git-send-email-ssengar@linux.microsoft.com>

On Tue, Jun 27 2023 at 00:28, Saurabh Sengar wrote:
> Hyper-V has usecases where it need to fetch NUMA information from
> Devicetree. Currently, it is not possible to extract the NUMA
> information from Devicetree for x86 arch.
>
> Add support for Devicetree in the x86_numa_init function, allowing
> the retrieval of NUMA node information from the Devicetree.
>
> Additionally, relocate the x86_dtb_init function before initmem_init
> to ensure the Devicetree initialization prior to its utilization in
> x86_numa_init.

Moving dtb_init() is not really a good idea. The APIC/IO-APIC
enumeration is post initmem_init() on purpose and the ongoing rework of
the topology evaluation relies on that.

What you really want is to split dtb_init() into two parts:

   1) x86_flattree_get_config() which can be invoked before initmem init
      like ACPI has an early init part so SRAT parsing can be done in
      the numa initialization.

   2) The APIC/IOAPIC registration part, which stays where it is.

This split wants to be a seperate change.

Thanks,

        tglx



   

  parent reply	other threads:[~2023-08-24 15:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-27  7:28 [PATCH] x86/numa: Add Devicetree support Saurabh Sengar
2023-07-12  8:11 ` Saurabh Singh Sengar
2023-07-27  8:06   ` Saurabh Singh Sengar
2023-08-02 18:49 ` Michael Kelley (LINUX)
2023-08-11 10:29   ` Saurabh Singh Sengar
2023-08-24  5:16     ` Saurabh Singh Sengar
2023-08-24 15:28 ` Thomas Gleixner [this message]
2023-08-24 15:59   ` Saurabh Singh Sengar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87edjscvdm.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mikelley@microsoft.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=ssengar@linux.microsoft.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox