From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B777C77B7C for ; Thu, 11 May 2023 16:06:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238449AbjEKQGT (ORCPT ); Thu, 11 May 2023 12:06:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237852AbjEKQGR (ORCPT ); Thu, 11 May 2023 12:06:17 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 552FD2683 for ; Thu, 11 May 2023 09:06:16 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 10DDC1FF6A; Thu, 11 May 2023 16:06:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1683821175; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YJckLey2rE6VlDnueYStqSpphJd9RqYm1BabcoHNEPc=; b=tz+kh13QsgrUgtRdwIXVmBM2aZDqM1so8lhj6k/FKawaBu6NzApPenr6iOgUBGjEHfJbLX q9dN7dMII0mlA9mEbgaQBBJ6AoyQEjBD4+Xa1Yg29dSmMNmGVkQvALK7x6kvvGGNV1p9t6 X36jMQmEH07j/tl+KiqNIDkltR5bLjw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1683821175; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YJckLey2rE6VlDnueYStqSpphJd9RqYm1BabcoHNEPc=; b=xxGYa1rdGqsnllvCimWrm9cOb28bsSBtdGBmbhdkcZWyqsaoOwtO7i1kjYpV0KRO/I0LfV SQITYvX00jKC1pCA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BB58A134B2; Thu, 11 May 2023 16:06:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id JvSHLHYSXWRIBAAAMHmgww (envelope-from ); Thu, 11 May 2023 16:06:14 +0000 Date: Thu, 11 May 2023 18:06:14 +0200 Message-ID: <87ednm4zux.wl-tiwai@suse.de> From: Takashi Iwai To: nemesis@icequake.net Cc: alsa-devel@alsa-project.org, Jaroslav Kysela , Stefan Binding , Meng Tang , Andy Chi , "Luke D. Jones" , Philipp Jungkamp , Kacper =?ISO-8859-2?Q?Michaj=B3ow?= , Yuchi Yang , linux-kernel@vger.kernel.org Subject: Re: [PATCH] snd-hda-intel: Apply HP B&O top speaker profile to Pavilion 15 In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 10 May 2023 18:19:08 +0200, Ryan C. Underwood wrote: > > > The Pavilion 15 line has B&O top speakers similar to the x360 and > applying the same profile produces good sound. Without this, the sound > would be tinny and underpowered without either applying > model=alc295-hp-x360 or booting another OS first. The code change looks OK, but could you give your Signed-off-by tag? It's a legal requirement and mandatory for merging to the upstream. Also, you can reduce the recipients in Cc a bit more. For this kind of trivial change, just maintainers and ML should suffice. thanks, Takashi