* [PATCH 1/2] ALSA: hda/realtek: fix mute/micmute LEDs don't work for a HP platform.
@ 2023-02-14 3:58 Andy Chi
2023-02-14 3:58 ` [PATCH 2/2] ALSA: hda/realtek: Enable mute/micmute LEDs support for HP Laptops Andy Chi
2023-02-14 10:25 ` [PATCH 1/2] ALSA: hda/realtek: fix mute/micmute LEDs don't work for a HP platform Takashi Iwai
0 siblings, 2 replies; 8+ messages in thread
From: Andy Chi @ 2023-02-14 3:58 UTC (permalink / raw)
Cc: andy.chi, Jaroslav Kysela, Takashi Iwai, Tim Crawford,
Stefan Binding, Meng Tang, Philipp Jungkamp,
Kacper Michajłow, Gabriele Mazzotta, Yuchi Yang, alsa-devel,
linux-kernel
There is a HP platform needs ALC236_FIXUP_HP_GPIO_LED quirk to
make mic-mute/audio-mute working.
Signed-off-by: Andy Chi <andy.chi@canonical.com>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 1134a493d225..7b9fb38ff732 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9436,6 +9436,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x8b5e, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
SND_PCI_QUIRK(0x103c, 0x8b7a, "HP", ALC236_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8b7d, "HP", ALC236_FIXUP_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x8b87, "HP", ALC236_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8b8a, "HP", ALC236_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8b8b, "HP", ALC236_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8b8d, "HP", ALC236_FIXUP_HP_GPIO_LED),
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/2] ALSA: hda/realtek: Enable mute/micmute LEDs support for HP Laptops
2023-02-14 3:58 [PATCH 1/2] ALSA: hda/realtek: fix mute/micmute LEDs don't work for a HP platform Andy Chi
@ 2023-02-14 3:58 ` Andy Chi
2023-02-14 10:24 ` Takashi Iwai
2023-02-14 10:25 ` [PATCH 1/2] ALSA: hda/realtek: fix mute/micmute LEDs don't work for a HP platform Takashi Iwai
1 sibling, 1 reply; 8+ messages in thread
From: Andy Chi @ 2023-02-14 3:58 UTC (permalink / raw)
Cc: andy.chi, Jaroslav Kysela, Takashi Iwai, Tim Crawford,
Stefan Binding, Meng Tang, Philipp Jungkamp,
Kacper Michajłow, Gabriele Mazzotta, Yuchi Yang, alsa-devel,
linux-kernel
On HP Laptops, requires the same ALC285_FIXUP_HP_GPIO_LED quirk to
make its audio LEDs work.
Signed-off-by: Andy Chi <andy.chi@canonical.com>
---
sound/pci/hda/patch_realtek.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 7b9fb38ff732..e2cd5456f2a6 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9432,6 +9432,12 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x8abb, "HP ZBook Firefly 14 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8ad1, "HP EliteBook 840 14 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8ad2, "HP EliteBook 860 16 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x8b42, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x8b43, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x8b44, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x8b45, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x8b46, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x8b47, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8b5d, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
SND_PCI_QUIRK(0x103c, 0x8b5e, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
SND_PCI_QUIRK(0x103c, 0x8b7a, "HP", ALC236_FIXUP_HP_GPIO_LED),
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] ALSA: hda/realtek: Enable mute/micmute LEDs support for HP Laptops
2023-02-14 3:58 ` [PATCH 2/2] ALSA: hda/realtek: Enable mute/micmute LEDs support for HP Laptops Andy Chi
@ 2023-02-14 10:24 ` Takashi Iwai
0 siblings, 0 replies; 8+ messages in thread
From: Takashi Iwai @ 2023-02-14 10:24 UTC (permalink / raw)
To: Andy Chi
Cc: Jaroslav Kysela, Takashi Iwai, Tim Crawford, Stefan Binding,
Meng Tang, Philipp Jungkamp, Kacper Michajłow,
Gabriele Mazzotta, Yuchi Yang, alsa-devel, linux-kernel
On Tue, 14 Feb 2023 04:58:52 +0100,
Andy Chi wrote:
>
> On HP Laptops, requires the same ALC285_FIXUP_HP_GPIO_LED quirk to
> make its audio LEDs work.
This doesn't match with the actual change? It appears to be the
additional quirk for Cirrus amps.
Takashi
>
> Signed-off-by: Andy Chi <andy.chi@canonical.com>
> ---
> sound/pci/hda/patch_realtek.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 7b9fb38ff732..e2cd5456f2a6 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -9432,6 +9432,12 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x103c, 0x8abb, "HP ZBook Firefly 14 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x8ad1, "HP EliteBook 840 14 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x8ad2, "HP EliteBook 860 16 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> + SND_PCI_QUIRK(0x103c, 0x8b42, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> + SND_PCI_QUIRK(0x103c, 0x8b43, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> + SND_PCI_QUIRK(0x103c, 0x8b44, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> + SND_PCI_QUIRK(0x103c, 0x8b45, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> + SND_PCI_QUIRK(0x103c, 0x8b46, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> + SND_PCI_QUIRK(0x103c, 0x8b47, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x8b5d, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
> SND_PCI_QUIRK(0x103c, 0x8b5e, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
> SND_PCI_QUIRK(0x103c, 0x8b7a, "HP", ALC236_FIXUP_HP_GPIO_LED),
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] ALSA: hda/realtek: fix mute/micmute LEDs don't work for a HP platform.
2023-02-14 3:58 [PATCH 1/2] ALSA: hda/realtek: fix mute/micmute LEDs don't work for a HP platform Andy Chi
2023-02-14 3:58 ` [PATCH 2/2] ALSA: hda/realtek: Enable mute/micmute LEDs support for HP Laptops Andy Chi
@ 2023-02-14 10:25 ` Takashi Iwai
2023-02-14 10:37 ` [PATCH v2] ALSA: hda/realtek: Enable mute/micmute LEDs support for HP Laptops Andy Chi
1 sibling, 1 reply; 8+ messages in thread
From: Takashi Iwai @ 2023-02-14 10:25 UTC (permalink / raw)
To: Andy Chi
Cc: Jaroslav Kysela, Takashi Iwai, Tim Crawford, Stefan Binding,
Meng Tang, Philipp Jungkamp, Kacper Michajłow,
Gabriele Mazzotta, Yuchi Yang, alsa-devel, linux-kernel
On Tue, 14 Feb 2023 04:58:51 +0100,
Andy Chi wrote:
>
> There is a HP platform needs ALC236_FIXUP_HP_GPIO_LED quirk to
> make mic-mute/audio-mute working.
>
> Signed-off-by: Andy Chi <andy.chi@canonical.com>
Applied this one (but the second one looks dubious).
thanks,
Takashi
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] ALSA: hda/realtek: Enable mute/micmute LEDs support for HP Laptops
2023-02-14 10:25 ` [PATCH 1/2] ALSA: hda/realtek: fix mute/micmute LEDs don't work for a HP platform Takashi Iwai
@ 2023-02-14 10:37 ` Andy Chi
2023-02-14 11:27 ` Takashi Iwai
0 siblings, 1 reply; 8+ messages in thread
From: Andy Chi @ 2023-02-14 10:37 UTC (permalink / raw)
Cc: andy.chi, Jaroslav Kysela, Takashi Iwai, Tim Crawford,
Stefan Binding, Meng Tang, Philipp Jungkamp,
Kacper Michajłow, Gabriele Mazzotta, Yuchi Yang, alsa-devel,
linux-kernel
On HP Laptops, requires the same ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED quirk to
make its audio LEDs work.
Signed-off-by: Andy Chi <andy.chi@canonical.com>
v2: Modify the commit message to the correct quirk.
---
sound/pci/hda/patch_realtek.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 7b9fb38ff732..e2cd5456f2a6 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9432,6 +9432,12 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x8abb, "HP ZBook Firefly 14 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8ad1, "HP EliteBook 840 14 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8ad2, "HP EliteBook 860 16 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x8b42, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x8b43, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x8b44, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x8b45, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x8b46, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x8b47, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8b5d, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
SND_PCI_QUIRK(0x103c, 0x8b5e, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
SND_PCI_QUIRK(0x103c, 0x8b7a, "HP", ALC236_FIXUP_HP_GPIO_LED),
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2] ALSA: hda/realtek: Enable mute/micmute LEDs support for HP Laptops
2023-02-14 10:37 ` [PATCH v2] ALSA: hda/realtek: Enable mute/micmute LEDs support for HP Laptops Andy Chi
@ 2023-02-14 11:27 ` Takashi Iwai
2023-02-14 14:04 ` [PATCH v3] ALSA: hda/realtek: Enable mute/micmute LEDs and speaker " Andy Chi
0 siblings, 1 reply; 8+ messages in thread
From: Takashi Iwai @ 2023-02-14 11:27 UTC (permalink / raw)
To: Andy Chi
Cc: Jaroslav Kysela, Takashi Iwai, Tim Crawford, Stefan Binding,
Meng Tang, Philipp Jungkamp, Kacper Michajłow,
Gabriele Mazzotta, Yuchi Yang, alsa-devel, linux-kernel
On Tue, 14 Feb 2023 11:37:56 +0100,
Andy Chi wrote:
>
> On HP Laptops, requires the same ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED quirk to
> make its audio LEDs work.
Well, this quirk is not only about mute/mic LED but rather mainly for
enabling the Cirrus amp. I suppose the speaker didn't work without
this quirk, too?
Takashi
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v3] ALSA: hda/realtek: Enable mute/micmute LEDs and speaker support for HP Laptops
2023-02-14 11:27 ` Takashi Iwai
@ 2023-02-14 14:04 ` Andy Chi
2023-02-14 14:07 ` Takashi Iwai
0 siblings, 1 reply; 8+ messages in thread
From: Andy Chi @ 2023-02-14 14:04 UTC (permalink / raw)
Cc: andy.chi, Jaroslav Kysela, Takashi Iwai, Tim Crawford,
Stefan Binding, Meng Tang, Philipp Jungkamp,
Kacper Michajłow, Gabriele Mazzotta, Yuchi Yang, alsa-devel,
linux-kernel
On HP Laptops, requires the ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED quirk to
make its audio LEDs and speaker work.
Signed-off-by: Andy Chi <andy.chi@canonical.com>
v3: mentioned that this quirk also fix speaker in commit message
---
sound/pci/hda/patch_realtek.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 7b9fb38ff732..e2cd5456f2a6 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9432,6 +9432,12 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x8abb, "HP ZBook Firefly 14 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8ad1, "HP EliteBook 840 14 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8ad2, "HP EliteBook 860 16 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x8b42, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x8b43, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x8b44, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x8b45, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x8b46, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x8b47, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8b5d, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
SND_PCI_QUIRK(0x103c, 0x8b5e, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
SND_PCI_QUIRK(0x103c, 0x8b7a, "HP", ALC236_FIXUP_HP_GPIO_LED),
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v3] ALSA: hda/realtek: Enable mute/micmute LEDs and speaker support for HP Laptops
2023-02-14 14:04 ` [PATCH v3] ALSA: hda/realtek: Enable mute/micmute LEDs and speaker " Andy Chi
@ 2023-02-14 14:07 ` Takashi Iwai
0 siblings, 0 replies; 8+ messages in thread
From: Takashi Iwai @ 2023-02-14 14:07 UTC (permalink / raw)
To: Andy Chi
Cc: Jaroslav Kysela, Takashi Iwai, Tim Crawford, Stefan Binding,
Meng Tang, Philipp Jungkamp, Kacper Michajłow,
Gabriele Mazzotta, Yuchi Yang, alsa-devel, linux-kernel
On Tue, 14 Feb 2023 15:04:31 +0100,
Andy Chi wrote:
>
> On HP Laptops, requires the ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED quirk to
> make its audio LEDs and speaker work.
>
> Signed-off-by: Andy Chi <andy.chi@canonical.com>
>
> v3: mentioned that this quirk also fix speaker in commit message
Thanks, applied.
Takashi
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-02-14 14:10 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-14 3:58 [PATCH 1/2] ALSA: hda/realtek: fix mute/micmute LEDs don't work for a HP platform Andy Chi
2023-02-14 3:58 ` [PATCH 2/2] ALSA: hda/realtek: Enable mute/micmute LEDs support for HP Laptops Andy Chi
2023-02-14 10:24 ` Takashi Iwai
2023-02-14 10:25 ` [PATCH 1/2] ALSA: hda/realtek: fix mute/micmute LEDs don't work for a HP platform Takashi Iwai
2023-02-14 10:37 ` [PATCH v2] ALSA: hda/realtek: Enable mute/micmute LEDs support for HP Laptops Andy Chi
2023-02-14 11:27 ` Takashi Iwai
2023-02-14 14:04 ` [PATCH v3] ALSA: hda/realtek: Enable mute/micmute LEDs and speaker " Andy Chi
2023-02-14 14:07 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox