Re: [RFC PATCH 02/14] ASoC: qcom: qdsp6: Introduce USB AFE port to q6dsp

Wesley Cheng
2023-01-06T01:33:54Z

Hi Krzysztof,

On 1/5/2023 10:09 AM, Krzysztof Kozlowski wrote:
> On 24/12/2022 00:31, Wesley Cheng wrote:
>> The QC ADSP is able to support USB playback and capture, so that the
>> main application processor can be placed into lower CPU power modes. This
>> adds the required AFE port configurations and port start command to start
>> an audio session.
>>
>> Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
>> ---
>> .../sound/qcom,q6dsp-lpass-ports.h | 1 +
>> sound/soc/qcom/qdsp6/q6afe-dai.c | 47 +++++
>> sound/soc/qcom/qdsp6/q6afe.c | 183 ++++++++++++++++++
>> sound/soc/qcom/qdsp6/q6afe.h | 46 ++++-
>> sound/soc/qcom/qdsp6/q6dsp-lpass-ports.c | 23 +++
>> sound/soc/qcom/qdsp6/q6dsp-lpass-ports.h | 1 +
>> sound/soc/qcom/qdsp6/q6routing.c | 8 +
>> 7 files changed, 308 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h b/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h
>> index 9f7c5103bc82..746bc462bb2e 100644
>> --- a/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h
>> +++ b/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h
>> @@ -131,6 +131,7 @@
>> #define RX_CODEC_DMA_RX_7 126
>> #define QUINARY_MI2S_RX 127
>> #define QUINARY_MI2S_TX 128
>> +#define USB_RX 129
>>
>> #define LPASS_CLK_ID_PRI_MI2S_IBIT 1
>
> Bindings are separate patches. Please split.
>

Thanks for catching this. Will do.

Thanks
Wesley Cheng