Re: [PATCH v5 6/7] cpufreq: amd-pstate: update pstate frequency transition delay time

Punit Agrawal
2022-08-15T15:06:02Z

Perry Yuan <Perry.Yuan@amd.com> writes:

> Change the default transition latency to be 20ms that is more
> reasonable transition delay for AMD processors in non-EPP driver mode.
>
> Update transition delay time to 1ms, in the AMD CPU autonomous mode and
> non-autonomous mode, CPPC firmware will decide frequency at 1ms timescale
> based on the workload utilization.
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
> ---
> drivers/cpufreq/amd-pstate.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index e40177d14310..9cb051d61422 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -41,8 +41,8 @@
> #include <asm/msr.h>
> #include "amd-pstate-trace.h"
>
> -#define AMD_PSTATE_TRANSITION_LATENCY 0x20000
> -#define AMD_PSTATE_TRANSITION_DELAY 500
> +#define AMD_PSTATE_TRANSITION_LATENCY 20000
> +#define AMD_PSTATE_TRANSITION_DELAY 1000

How were these values derived? If from documentation, it'll be good to
add a link to the relevant documentation. And if they were derived from
testing, please mention this in the commit log (along with some details
of the tests used to determine the value).

>
> /*
> * TODO: We need more time to fine tune processors with shared memory solution