From: Michael Ellerman <mpe@ellerman.id.au>
To: Yury Norov <yury.norov@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Cc: Yury Norov <yury.norov@gmail.com>
Subject: Re: [GIT PULL] Bitmap patches for v6.0-rc1
Date: Sat, 06 Aug 2022 16:11:17 +1000 [thread overview]
Message-ID: <87edxtaol6.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <20220805022940.1637978-1-yury.norov@gmail.com>
Hi Linus,
This pull request has a conflict with the random tree in some powerpc
code.
The random tree removed CONFIG_ARCH_RANDOM and changed the arguments and
names of the arch_get_random_xxx() calls, meanwhile the commit in the
bitmap tree moved our arch_get_random_seed_long() into a C file.
Yury Norov <yury.norov@gmail.com> writes:
> The following changes since commit a111daf0c53ae91e71fd2bfe7497862d14132e3e:
>
> Linux 5.19-rc3 (2022-06-19 15:06:47 -0500)
>
> are available in the Git repository at:
>
> https://github.com/norov/linux.git/ tags/bitmap-6.0-rc1
>
> for you to fetch changes up to 36d4b36b69590fed99356a4426c940a253a93800:
>
> lib/nodemask: inline next_node_in() and node_random() (2022-08-01 08:13:21 -0700)
...
> arch/powerpc/include/asm/archrandom.h | 9 +-
> arch/powerpc/kernel/setup-common.c | 12 +
There is a textual conflict in archrandom.h. But there's also a fixup
needed in setup-common.c.
Mark spotted it in linux-next but the resolution is not quite right, I
describe the correct result here:
https://lore.kernel.org/all/87h72q9bgg.fsf@mpe.ellerman.id.au/T/#m068009a89d2412dd4ca14ac598a7d6b8288d4568
Or the end state is attached below.
cheers
==== arch/powerpc/kernel/setup-common.c ====
...
size_t __must_check arch_get_random_seed_longs(unsigned long *v, size_t max_longs)
{
if (max_longs && ppc_md.get_random_seed && ppc_md.get_random_seed(v))
return 1;
return 0;
}
EXPORT_SYMBOL(arch_get_random_seed_longs);
...
==== arch/powerpc/include/asm/archrandom.h ====
/* SPDX-License-Identifier: GPL-2.0 */
#ifndef _ASM_POWERPC_ARCHRANDOM_H
#define _ASM_POWERPC_ARCHRANDOM_H
static inline size_t __must_check arch_get_random_longs(unsigned long *v, size_t max_longs)
{
return 0;
}
size_t __must_check arch_get_random_seed_longs(unsigned long *v, size_t max_longs);
#ifdef CONFIG_PPC_POWERNV
int pnv_get_random_long(unsigned long *v);
#endif
#endif /* _ASM_POWERPC_ARCHRANDOM_H */
next prev parent reply other threads:[~2022-08-06 6:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 2:29 [GIT PULL] Bitmap patches for v6.0-rc1 Yury Norov
2022-08-06 6:11 ` Michael Ellerman [this message]
2022-08-08 0:49 ` Linus Torvalds
2022-08-08 6:10 ` Michael Ellerman
2022-08-08 0:12 ` Linus Torvalds
2022-08-12 6:15 ` Yury Norov
2022-08-08 0:48 ` pr-tracker-bot
2022-08-08 0:57 ` Linus Torvalds
2022-08-08 4:21 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edxtaol6.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox