From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A3E4C43334 for ; Sat, 23 Jul 2022 08:04:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231783AbiGWIEP (ORCPT ); Sat, 23 Jul 2022 04:04:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230217AbiGWIEM (ORCPT ); Sat, 23 Jul 2022 04:04:12 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 493BD15FE1; Sat, 23 Jul 2022 01:04:11 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BC130386FE; Sat, 23 Jul 2022 08:04:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1658563449; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Y9QhawCkHKsCiHHgfi8GWHnlEnHkEPLxtn8NZEM6LSY=; b=utorI0k/pk3RICH03mAA2PG7LoWXNki4Wi1Qrk/0iwrxbkp9KhsQGOSD8WnSbqQP1yXRac +zqoKEL7F2e3viCe4EZrqmtlj6sbUspVcOiNzX5XJiUopUp3uW7vSv06RSGtkOhrRgsnxO vm4e2/vgXM3oym6T5QsC0/SaOrV4Iac= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1658563449; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Y9QhawCkHKsCiHHgfi8GWHnlEnHkEPLxtn8NZEM6LSY=; b=te239ay+Rhoi2TvqvwNKOjFkS/95RSnnF7C5ErBWDMbKuwQrCOFht9hnIUwhMdwjmHFzu0 XD3j5amzFiiJAmCA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 95BB913A92; Sat, 23 Jul 2022 08:04:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id IqbJI3mr22IyFAAAMHmgww (envelope-from ); Sat, 23 Jul 2022 08:04:09 +0000 Date: Sat, 23 Jul 2022 10:04:09 +0200 Message-ID: <87edyc2r2e.wl-tiwai@suse.de> From: Takashi Iwai To: Joe Perches Cc: linux-fsdevel@vger.kernel.org, Namjae Jeon , Sungjong Seo , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] exfat: Expand exfat_err() and co directly to pr_*() macro In-Reply-To: <0350c21bcfdc896f2b912363f221958d41ebf1e1.camel@perches.com> References: <20220722142916.29435-1-tiwai@suse.de> <20220722142916.29435-4-tiwai@suse.de> <0350c21bcfdc896f2b912363f221958d41ebf1e1.camel@perches.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 23 Jul 2022 09:42:12 +0200, Joe Perches wrote: > > On Fri, 2022-07-22 at 16:29 +0200, Takashi Iwai wrote: > > Currently the error and info messages handled by exfat_err() and co > > are tossed to exfat_msg() function that does nothing but passes the > > strings with printk() invocation. Not only that this is more overhead > > by the indirect calls, but also this makes harder to extend for the > > debug print usage; because of the direct printk() call, you cannot > > make it for dynamic debug or without debug like the standard helpers > > such as pr_debug() or dev_dbg(). > > > > For addressing the problem, this patch replaces exfat_msg() function > > with a macro to expand to pr_*() directly. This allows us to create > > exfat_debug() macro that is expanded to pr_debug() (which output can > > gracefully suppressed via dyndbg). > [] > > diff --git a/fs/exfat/exfat_fs.h b/fs/exfat/exfat_fs.h > [] > > @@ -508,14 +508,19 @@ void __exfat_fs_error(struct super_block *sb, int report, const char *fmt, ...) > > #define exfat_fs_error_ratelimit(sb, fmt, args...) \ > > __exfat_fs_error(sb, __ratelimit(&EXFAT_SB(sb)->ratelimit), \ > > fmt, ## args) > > -void exfat_msg(struct super_block *sb, const char *lv, const char *fmt, ...) > > - __printf(3, 4) __cold; > > + > > +/* expand to pr_xxx() with prefix */ > > +#define exfat_msg(sb, lv, fmt, ...) \ > > + pr_##lv("exFAT-fs (%s): " fmt "\n", (sb)->s_id, ##__VA_ARGS__) > > + > > #define exfat_err(sb, fmt, ...) \ > > - exfat_msg(sb, KERN_ERR, fmt, ##__VA_ARGS__) > > + exfat_msg(sb, err, fmt, ##__VA_ARGS__) > > #define exfat_warn(sb, fmt, ...) \ > > - exfat_msg(sb, KERN_WARNING, fmt, ##__VA_ARGS__) > > + exfat_msg(sb, warn, fmt, ##__VA_ARGS__) > > #define exfat_info(sb, fmt, ...) \ > > - exfat_msg(sb, KERN_INFO, fmt, ##__VA_ARGS__) > > + exfat_msg(sb, info, fmt, ##__VA_ARGS__) > > +#define exfat_debug(sb, fmt, ...) \ > > + exfat_msg(sb, debug, fmt, ##__VA_ARGS__) > > I think this would be clearer using pr_ directly instead > of an indirecting macro that uses concatenation of that > obscures the actual use of pr_ > > Either: (and this first option would be my preference) > > #define exfat_err(sb, fmt, ...) \ > pr_err("exFAT-fs (%s): " fmt "\n", (sb)->s_id, ##__VA_ARGS__) > #define exfat_warn(sb, fmt, ...) \ > pr_warn("exFAT-fs (%s): " fmt "\n", (sb)->s_id, ##__VA_ARGS__) > etc... IMO, it's a matter of taste, and I don't mind either way. Just let me know. > or using an indirecting macro: > > #define exfat_printk(pr_level, sb, fmt, ...) \ > pr_level("exFAT-fs (%s): " fmt "\n", (sb)->s_id, ##__VA_ARGS__) Is pr_level() defined anywhere...? > > and btw, there are multiple uses of exfat_ output with a > unnecessary and duplicated '\n' that the macro already adds that > should be removed: > > $ git grep -P -n '\bexfat_(err|warn|info).*\\n' fs/exfat/ > fs/exfat/fatent.c:334: exfat_err(sb, "sbi->clu_srch_ptr is invalid (%u)\n", > fs/exfat/nls.c:674: exfat_err(sb, "failed to read sector(0x%llx)\n", > fs/exfat/super.c:467: exfat_err(sb, "bogus sector size bits : %u\n", > fs/exfat/super.c:476: exfat_err(sb, "bogus sectors bits per cluster : %u\n", Right, that should be addressed in another patch. thanks, Takashi