From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B41BC43334 for ; Wed, 22 Jun 2022 12:17:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236113AbiFVMRH (ORCPT ); Wed, 22 Jun 2022 08:17:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235799AbiFVMQ4 (ORCPT ); Wed, 22 Jun 2022 08:16:56 -0400 Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [217.70.178.231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DF88340C6; Wed, 22 Jun 2022 05:16:53 -0700 (PDT) Received: (Authenticated sender: peter@korsgaard.com) by mail.gandi.net (Postfix) with ESMTPSA id 5FCDB10000A; Wed, 22 Jun 2022 12:16:47 +0000 (UTC) Received: from peko by dell.be.48ers.dk with local (Exim 4.94.2) (envelope-from ) id 1o3zHr-0099t6-5Y; Wed, 22 Jun 2022 14:16:47 +0200 From: Peter Korsgaard To: Nava kishore Manne Cc: , , , , , , , , , , , , , , , Subject: Re: [PATCH v2 3/3] fpga: zynqmp-fpga: Adds status interface References: <20220621092833.1057408-1-nava.manne@xilinx.com> <20220621092833.1057408-4-nava.manne@xilinx.com> Date: Wed, 22 Jun 2022 14:16:47 +0200 In-Reply-To: <20220621092833.1057408-4-nava.manne@xilinx.com> (Nava kishore Manne's message of "Tue, 21 Jun 2022 14:58:33 +0530") Message-ID: <87edzg51w0.fsf@dell.be.48ers.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Nava" == Nava kishore Manne writes: > Adds status interface for zynqmp-fpga, It's a read only > interface which allows the user to get the PL status. > Usage: > To read the PL configuration status > cat /sys/class/fpga_manager//status > Signed-off-by: Nava kishore Manne > --- > Changes for v2: > - Updated status messages handling logic as suggested by Xu Yilun. > drivers/fpga/zynqmp-fpga.c | 53 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 53 insertions(+) > diff --git a/drivers/fpga/zynqmp-fpga.c b/drivers/fpga/zynqmp-fpga.c > index c60f20949c47..e194bba91d3f 100644 > --- a/drivers/fpga/zynqmp-fpga.c > +++ b/drivers/fpga/zynqmp-fpga.c > @@ -14,6 +14,19 @@ > /* Constant Definitions */ > #define IXR_FPGA_DONE_MASK BIT(3) > +#define READ_DMA_SIZE 256U > + > +/* Error Register */ > +#define IXR_FPGA_ERR_CRC_ERR BIT(0) > +#define IXR_FPGA_ERR_SECURITY_ERR BIT(16) > + > +/* Signal Status Register. For details refer ug570 */ > +#define IXR_FPGA_END_OF_STARTUP BIT(4) > +#define IXR_FPGA_GST_CFG_B BIT(5) > +#define IXR_FPGA_INIT_B_INTERNAL BIT(11) > +#define IXR_FPGA_DONE_INTERNAL_SIGNAL BIT(13) > + > +#define IXR_FPGA_CONFIG_STAT_OFFSET 7U > /** > * struct zynqmp_fpga_priv - Private data structure > @@ -77,8 +90,48 @@ static enum fpga_mgr_states zynqmp_fpga_ops_state(struct fpga_manager *mgr) > return FPGA_MGR_STATE_UNKNOWN; > } > +static ssize_t zynqmp_fpga_ops_status(struct fpga_manager *mgr, char *buf) > +{ > + unsigned int *kbuf, reg_val; > + dma_addr_t dma_addr; > + ssize_t len = 0; > + int ret; > + > + kbuf = dma_alloc_coherent(mgr->dev.parent, READ_DMA_SIZE, > + &dma_addr, GFP_KERNEL); > + if (!kbuf) > + return -ENOMEM; What is kbuf used for? You don't seem to ever access it? -- Bye, Peter Korsgaard