From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F3AECCA47F for ; Mon, 13 Jun 2022 05:45:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237035AbiFMFor (ORCPT ); Mon, 13 Jun 2022 01:44:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232665AbiFMFnM (ORCPT ); Mon, 13 Jun 2022 01:43:12 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40EC413DCF for ; Sun, 12 Jun 2022 22:41:14 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E19551F91B; Mon, 13 Jun 2022 05:41:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1655098872; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3dINdTPcWskYcY4vaHavZqUpGKTEZb/iEHgT5+r3rkI=; b=sEUK/XO2825jyPzqfgauovi913iP9V+rVVL1jeonqZUh91YxzlEYTnvaNHJtAio13YBdPo v/oPSVzDCPpZ8kP8EVevZuSY6pRt7G50Z1h9W8KJyDZ9t4u+dICM1HcX2b4QtTTqarla4y aVuptZqZpvR/GfdWlY5slmMieU8Cihg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1655098872; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3dINdTPcWskYcY4vaHavZqUpGKTEZb/iEHgT5+r3rkI=; b=BVoNivKBgpz8BtiMTCIHUiwn5BoVYysZMR6nylaDkjCiLtcmPu3dzuGkGq/7oot3uFd/CK 8lnEtn3nQbAz0HAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B24F113941; Mon, 13 Jun 2022 05:41:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id qyWdKfjNpmJ3bQAAMHmgww (envelope-from ); Mon, 13 Jun 2022 05:41:12 +0000 Date: Mon, 13 Jun 2022 07:41:12 +0200 Message-ID: <87edztt91j.wl-tiwai@suse.de> From: Takashi Iwai To: Daniil Dementev Cc: Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Alexey Khoroshilov Subject: Re: [PATCH] ALSA: usb-audio: US16x08: Move overflow check before array access In-Reply-To: <20220610165732.2904-1-d.dementev@ispras.ru> References: <20220610165732.2904-1-d.dementev@ispras.ru> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 10 Jun 2022 18:57:32 +0200, Daniil Dementev wrote: > > Buffer overflow could occur in the loop "while", due to accessing an > array element before checking the index. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Signed-off-by: Daniil Dementev > Reviewed-by: Alexey Khoroshilov Thanks, applied. Takashi