From: "Luís Henriques" <lhenriques@suse.de>
To: Xiubo Li <xiubli@redhat.com>
Cc: Jeff Layton <jlayton@kernel.org>,
Ilya Dryomov <idryomov@gmail.com>,
ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/2] ceph: add support for encrypted snapshot names
Date: Tue, 15 Mar 2022 11:05:43 +0000 [thread overview]
Message-ID: <87ee33jx14.fsf@brahms.olymp> (raw)
In-Reply-To: <7aedb4b9-11e4-cfa1-986f-75cf8706c6c0@redhat.com> (Xiubo Li's message of "Tue, 15 Mar 2022 15:28:48 +0800")
Xiubo Li <xiubli@redhat.com> writes:
<...>
> I think there has one simple way. Just think about without setting the
> fscrypt_auth for the '.snap' dir's inode, that is without your this
> patch it works well.
>
> That's because when we create a snapshot under '.snap' dir, since the '.snap'
> dir related inode doesn't have the fscrypt_auth been filled, so when creating a
> new inode for the snapshot it won't fill the fscrypt_auth for the new inode. And
> then in the handle_reply() it can fill the fscrypt auth as expected.
>
> You can make sure that in the ceph_new_inode() just skip setting the
> fscrypt_auth for the new inode if the parent dir is a snapdir, that is
> '.snap/'. And this will just leave it to be filled in the handle_reply().
Ah! That's it! Great suggestion, I'll go test this and send out a new
version later. (And I think I'll need to rebase my patches on top of the
latest changes too.)
Cheers,
--
Luís
next prev parent reply other threads:[~2022-03-15 11:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 17:26 [RFC PATCH 0/2] Add support for snapshot names encryption Luís Henriques
2022-03-10 17:26 ` [RFC PATCH 1/2] ceph: add support for encrypted snapshot names Luís Henriques
2022-03-12 8:30 ` Xiubo Li
2022-03-14 2:45 ` Xiubo Li
2022-03-14 5:17 ` Xiubo Li
2022-03-14 11:07 ` Luís Henriques
2022-03-14 18:32 ` Luís Henriques
2022-03-15 7:28 ` Xiubo Li
2022-03-15 11:05 ` Luís Henriques [this message]
2022-03-10 17:26 ` [RFC PATCH 2/2] ceph: add support for handling encrypted snapshot names in subtree Luís Henriques
2022-03-14 8:54 ` Xiubo Li
2022-03-14 11:08 ` Luís Henriques
2022-03-10 17:34 ` [RFC PATCH 0/2] Add support for snapshot names encryption Luís Henriques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ee33jx14.fsf@brahms.olymp \
--to=lhenriques@suse.de \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=jlayton@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiubli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox