From: Marc Zyngier <maz@kernel.org>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
kernel-team@android.com, Jay Chen <jkchen@linux.alibaba.com>
Subject: Re: [PATCH v3] irqchip/gic-v3-its: Reset each ITS's BASERn register before probe
Date: Wed, 26 Jan 2022 11:10:14 +0000 [thread overview]
Message-ID: <87ee4u7nxl.wl-maz@kernel.org> (raw)
In-Reply-To: <20220126095726.GA23794@lpieralisi>
On Wed, 26 Jan 2022 09:57:26 +0000,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> wrote:
>
> > static void __init its_acpi_probe(void)
> > {
> > acpi_table_parse_srat_its();
> > - acpi_table_parse_madt(ACPI_MADT_TYPE_GENERIC_TRANSLATOR,
> > - gic_acpi_parse_madt_its, 0);
> > + if (acpi_table_parse_madt(ACPI_MADT_TYPE_GENERIC_TRANSLATOR,
> > + its_acpi_reset, 0) > 0)
> > + acpi_table_parse_madt(ACPI_MADT_TYPE_GENERIC_TRANSLATOR,
> > + gic_acpi_parse_madt_its, 0);
>
> Maybe it is worth adding a comment here as you did for DT if you
> can before merging it - to clarify the first acpi_table_parse_madt()
> call logic.
Sure, I'll add that.
>
> Other than that:
>
> Reviewed-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
prev parent reply other threads:[~2022-01-26 11:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 13:38 [PATCH v3] irqchip/gic-v3-its: Reset each ITS's BASERn register before probe Marc Zyngier
2022-01-26 9:57 ` Lorenzo Pieralisi
2022-01-26 11:10 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ee4u7nxl.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=jkchen@linux.alibaba.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).