From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEE3BC2BA4C for ; Wed, 26 Jan 2022 11:10:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240504AbiAZLKT (ORCPT ); Wed, 26 Jan 2022 06:10:19 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:33690 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240501AbiAZLKR (ORCPT ); Wed, 26 Jan 2022 06:10:17 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 675E261838 for ; Wed, 26 Jan 2022 11:10:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C310DC340E3; Wed, 26 Jan 2022 11:10:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643195416; bh=DY2kALKcas4I042KhkQH68h/5NU5TgoV24r7Ay4/74I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Tp6dMJh+C0xhPb+GSNcvVaabmJcpd0hqrWL7mz+CWGp314Vp49mhrO980Retxhc/F O21Uhhj4kSYAn/epWphJtzy4If5c61LBXgvVhq6H2/WHIlhd0BOmUuP+x+vQEjtFGE apNAhoUVVpxHAALVLnOZoQ6glu/jV3ai84HqK2e6X+JaVkPGMlHSGe/fQmBifMScA9 RcJMPJk8a/d4StEnMggp03Fv5ze9oXHLianR0awvsjKkRHy5aLSsUfHxqDkxhquHAi g5td3dqpKrv76TJXEvrIMqy2dkywXxxcLc67eas+d8t15nJxBxmR0B7TtlsMco4+py Gt8UEgElq5HlQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nCgBq-003BmH-Ho; Wed, 26 Jan 2022 11:10:14 +0000 Date: Wed, 26 Jan 2022 11:10:14 +0000 Message-ID: <87ee4u7nxl.wl-maz@kernel.org> From: Marc Zyngier To: Lorenzo Pieralisi Cc: linux-kernel@vger.kernel.org, Thomas Gleixner , kernel-team@android.com, Jay Chen Subject: Re: [PATCH v3] irqchip/gic-v3-its: Reset each ITS's BASERn register before probe In-Reply-To: <20220126095726.GA23794@lpieralisi> References: <20220124133809.1291195-1-maz@kernel.org> <20220126095726.GA23794@lpieralisi> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: lorenzo.pieralisi@arm.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, kernel-team@android.com, jkchen@linux.alibaba.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 26 Jan 2022 09:57:26 +0000, Lorenzo Pieralisi wrote: > > > static void __init its_acpi_probe(void) > > { > > acpi_table_parse_srat_its(); > > - acpi_table_parse_madt(ACPI_MADT_TYPE_GENERIC_TRANSLATOR, > > - gic_acpi_parse_madt_its, 0); > > + if (acpi_table_parse_madt(ACPI_MADT_TYPE_GENERIC_TRANSLATOR, > > + its_acpi_reset, 0) > 0) > > + acpi_table_parse_madt(ACPI_MADT_TYPE_GENERIC_TRANSLATOR, > > + gic_acpi_parse_madt_its, 0); > > Maybe it is worth adding a comment here as you did for DT if you > can before merging it - to clarify the first acpi_table_parse_madt() > call logic. Sure, I'll add that. > > Other than that: > > Reviewed-by: Lorenzo Pieralisi Thanks, M. -- Without deviation from the norm, progress is not possible.